Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: impl/prod/raw_datastore.go

Issue 1916463004: impl/memory: Disallow empty namespace. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master
Patch Set: Rbase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « impl/prod/info.go ('k') | service/datastore/checkfilter.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: impl/prod/raw_datastore.go
diff --git a/impl/prod/raw_datastore.go b/impl/prod/raw_datastore.go
index e58d3662051b101122ca03641509030b605498ba..0a638eecfd53c1bea34e99f08d3bf8bfac54d71b 100644
--- a/impl/prod/raw_datastore.go
+++ b/impl/prod/raw_datastore.go
@@ -6,7 +6,6 @@ package prod
import (
ds "github.com/luci/gae/service/datastore"
- "github.com/luci/gae/service/info"
"github.com/luci/luci-go/common/errors"
"golang.org/x/net/context"
"google.golang.org/appengine/datastore"
@@ -16,17 +15,16 @@ import (
// by gae.GetDS(c)
func useRDS(c context.Context) context.Context {
return ds.SetRawFactory(c, func(ci context.Context, wantTxn bool) ds.RawInterface {
- ns := info.Get(ci).GetNamespace()
maybeTxnCtx := AEContext(ci)
if wantTxn {
- return rdsImpl{ci, maybeTxnCtx, ns}
+ return rdsImpl{ci, maybeTxnCtx}
}
aeCtx := AEContextNoTxn(ci)
if maybeTxnCtx != aeCtx {
ci = context.WithValue(ci, prodContextKey, aeCtx)
}
- return rdsImpl{ci, aeCtx, ns}
+ return rdsImpl{ci, aeCtx}
})
}
@@ -39,8 +37,6 @@ type rdsImpl struct {
// aeCtx is the context with the appengine connection information in it.
aeCtx context.Context
-
- ns string
}
func idxCallbacker(err error, amt int, cb func(idx int, err error)) error {
« no previous file with comments | « impl/prod/info.go ('k') | service/datastore/checkfilter.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698