Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1916453002: Make DOMTokenList.prototype.toString enumerable. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DOMTokenList.prototype.toString enumerable. As 'stringifier' implies an enumerable toString(), drop the use of [NotEnumerable] for DOMTokenList's. This also aligns with other implementations (FF, Edge.) R=yoav@yoav.ws, philipj@opera.com BUG=306606 Committed: https://crrev.com/4178716d8d4ac70afd95a0131934fe533701bab5 Cr-Commit-Position: refs/heads/master@{#389442}

Patch Set 1 #

Patch Set 2 : update expected output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/interfaces-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMTokenList.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-22 19:51:47 UTC) #2
Yoav Weiss
On 2016/04/22 19:51:47, sof wrote: > please take a look. LGTM but as this is ...
4 years, 8 months ago (2016-04-24 06:05:24 UTC) #3
philipj_slow
lgtm
4 years, 8 months ago (2016-04-25 08:22:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916453002/20001
4 years, 8 months ago (2016-04-25 09:13:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 10:32:21 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 10:33:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4178716d8d4ac70afd95a0131934fe533701bab5
Cr-Commit-Position: refs/heads/master@{#389442}

Powered by Google App Engine
This is Rietveld 408576698