Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1916423003: Add a new 'optimize_no_wpo' compiler config to GN. (Closed)

Created:
4 years, 7 months ago by Sébastien Marchand
Modified:
4 years, 7 months ago
Reviewers:
brucedawson, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new 'optimize_no_wpo' compiler config to GN. This config will be used on the projects that don't support WPO (FFmpeg and Yasm). This config is a clone of the 'optimize' compiler config for now as we're not using WPO everywhere (it's only for the target building with the 'optimize_max' config). BUG=490934 Committed: https://crrev.com/bd3a9d19352bcbec819f22d69223cebcc2e92989 Cr-Commit-Position: refs/heads/master@{#390087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Sébastien Marchand
PTAL.
4 years, 7 months ago (2016-04-26 21:54:17 UTC) #3
scottmg
lgtm
4 years, 7 months ago (2016-04-26 21:56:41 UTC) #4
brucedawson
When switching this on (uncommenting the /GL line) you should try adding /LTCG to the ...
4 years, 7 months ago (2016-04-26 23:27:52 UTC) #5
Sébastien Marchand
Sure, I'll try to remove these warnings.
4 years, 7 months ago (2016-04-27 14:46:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916423003/1
4 years, 7 months ago (2016-04-27 14:46:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 15:50:51 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:10:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd3a9d19352bcbec819f22d69223cebcc2e92989
Cr-Commit-Position: refs/heads/master@{#390087}

Powered by Google App Engine
This is Rietveld 408576698