Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Side by Side Diff: test/mjsunit/regress/regress-crbug-605581.js

Issue 1916413002: [debugger] fix crash in debug-evaluate when retrieving values in TDZ. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@5.0
Patch Set: fix test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug-evaluate.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --expose-debug-as debug --allow-natives-syntax 5 // Flags: --expose-debug-as debug
6 6
7 var Debug = debug.Debug; 7 var Debug = debug.Debug;
8
9 var exception = null; 8 var exception = null;
10 9
11 function listener(event, exec_state, event_data, data) { 10 function listener(event, exec_state, event_data, data) {
12 if (event != Debug.DebugEvent.Break) return; 11 if (event != Debug.DebugEvent.Break) return;
13 try { 12 try {
14 var scope = exec_state.frame().scope(0); 13 assertThrows(() => exec_state.frame(0).evaluate("bar.baz"), ReferenceError);
15 assertEquals(5, scope.scopeObject().property("i").value().value());
16 } catch (e) { 14 } catch (e) {
17 exception = e; 15 exception = e;
18 } 16 }
19 } 17 }
20 18
21 function f() {
22 eval('var i = 5');
23 debugger;
24 }
25
26 f();
27 f();
28
29 %OptimizeFunctionOnNextCall(f);
30 Debug.setListener(listener); 19 Debug.setListener(listener);
31 20
32 f(); 21 (function() {
22 debugger; // bar is still in TDZ at this point.
23 let bar = 1;
24 (x => bar); // force bar to be context-allocated.
25 })();
33 26
27 Debug.setListener(null);
34 assertNull(exception); 28 assertNull(exception);
OLDNEW
« no previous file with comments | « src/debug/debug-evaluate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698