[wasm] Add tests for function name encoding

[wasm] Add tests for function name encoding

In order to have a wasm object (as JSObject), this adds a method to
instantiate the TestingModule. In order for this to work, the bytecode
and the function names of the TestingModule are stored for usage during
instantiation.

R=titzer@chromium.org

Committed: https://crrev.com/0d6d0b700f5ec87beff1d93a3fb423278f576d5c
Cr-Commit-Position: refs/heads/master@{#35906}

[titzer, 2016-04-28 11:38:23]

https://codereview.chromium.org/1916403002/diff/60001/test/cctest/wasm/test-w...
File test/cctest/wasm/test-wasm-function-name-table.cc (right):

https://codereview.chromium.org/1916403002/diff/60001/test/cctest/wasm/test-w...
test/cctest/wasm/test-wasm-function-name-table.cc:49: Handle<JSObject> wasm_obj
= module.Instantiate();
Ok, I see now.

The implication of using Instantiate() here is that the utilities in
wasm-run-utils.h need the additional capability of adding the bytes for function
names to the C++ WasmModule they build.

I think it'd be better to not use that utility (since it is mostly for running
code), and instead create WasmModule objects here in this test (perhaps with
some utilities).

That should be enough to be able to use module.Instantiate() here. If not, then
maybe we should add a special ForTesting() interface that only encodes the
function names.

https://codereview.chromium.org/1916403002/diff/60001/test/cctest/wasm/test-w...
test/cctest/wasm/test-wasm-function-name-table.cc:63: #define
TEST_CSTR_FUNNAMES(...)                                 \
You could probably do this with a helper function, which is nicer to debug. That
means the tests themselves might need to pass the number of strings, but it's
better than trying to debug through macro code.

[Clemens Hammacher, 2016-04-28 14:34:56]

https://codereview.chromium.org/1916403002/diff/60001/test/cctest/wasm/test-w...
File test/cctest/wasm/test-wasm-function-name-table.cc (right):

https://codereview.chromium.org/1916403002/diff/60001/test/cctest/wasm/test-w...
test/cctest/wasm/test-wasm-function-name-table.cc:49: Handle<JSObject> wasm_obj
= module.Instantiate();
On 2016/04/28 at 11:38:22, titzer wrote:
> Ok, I see now.
> 
> The implication of using Instantiate() here is that the utilities in
wasm-run-utils.h need the additional capability of adding the bytes for function
names to the C++ WasmModule they build.
> 
> I think it'd be better to not use that utility (since it is mostly for running
code), and instead create WasmModule objects here in this test (perhaps with
some utilities).
> 
> That should be enough to be able to use module.Instantiate() here. If not,
then maybe we should add a special ForTesting() interface that only encodes the
function names.

Yep, you are right. It was very easy to refactor the code to not use the
TestingModule at all.

https://codereview.chromium.org/1916403002/diff/60001/test/cctest/wasm/test-w...
test/cctest/wasm/test-wasm-function-name-table.cc:63: #define
TEST_CSTR_FUNNAMES(...)                                 \
On 2016/04/28 at 11:38:22, titzer wrote:
> You could probably do this with a helper function, which is nicer to debug.
That means the tests themselves might need to pass the number of strings, but
it's better than trying to debug through macro code.

Done.

[titzer, 2016-04-28 14:40:00]

On 2016/04/28 14:34:56, Clemens Hammacher wrote:
>
https://codereview.chromium.org/1916403002/diff/60001/test/cctest/wasm/test-w...
> File test/cctest/wasm/test-wasm-function-name-table.cc (right):
> 
>
https://codereview.chromium.org/1916403002/diff/60001/test/cctest/wasm/test-w...
> test/cctest/wasm/test-wasm-function-name-table.cc:49: Handle<JSObject>
wasm_obj
> = module.Instantiate();
> On 2016/04/28 at 11:38:22, titzer wrote:
> > Ok, I see now.
> > 
> > The implication of using Instantiate() here is that the utilities in
> wasm-run-utils.h need the additional capability of adding the bytes for
function
> names to the C++ WasmModule they build.
> > 
> > I think it'd be better to not use that utility (since it is mostly for
running
> code), and instead create WasmModule objects here in this test (perhaps with
> some utilities).
> > 
> > That should be enough to be able to use module.Instantiate() here. If not,
> then maybe we should add a special ForTesting() interface that only encodes
the
> function names.
> 
> Yep, you are right. It was very easy to refactor the code to not use the
> TestingModule at all.
> 
>
https://codereview.chromium.org/1916403002/diff/60001/test/cctest/wasm/test-w...
> test/cctest/wasm/test-wasm-function-name-table.cc:63: #define
> TEST_CSTR_FUNNAMES(...)                                 \
> On 2016/04/28 at 11:38:22, titzer wrote:
> > You could probably do this with a helper function, which is nicer to debug.
> That means the tests themselves might need to pass the number of strings, but
> it's better than trying to debug through macro code.
> 
> Done.

lgtm

[Clemens Hammacher, 2016-04-29 12:41:32]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-04-29 12:41:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916403002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916403002/80001

[commit-bot: I haz the power, 2016-04-29 12:43:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-01 22:03:48]

Description was changed from

==========
[wasm] Add tests for function name encoding

In order to have a wasm object (as JSObject), this adds a method to
instantiate the TestingModule. In order for this to work, the bytecode
and the function names of the TestingModule are stored for usage during
instantiation.

R=titzer@chromium.org
==========

to

==========
[wasm] Add tests for function name encoding

In order to have a wasm object (as JSObject), this adds a method to
instantiate the TestingModule. In order for this to work, the bytecode
and the function names of the TestingModule are stored for usage during
instantiation.

R=titzer@chromium.org

Committed: https://crrev.com/0d6d0b700f5ec87beff1d93a3fb423278f576d5c
Cr-Commit-Position: refs/heads/master@{#35906}
==========

[commit-bot: I haz the power, 2016-05-01 22:03:49]

Patchset 5 (id:??) landed as
https://crrev.com/0d6d0b700f5ec87beff1d93a3fb423278f576d5c
Cr-Commit-Position: refs/heads/master@{#35906}