Issue 19164003: Make optimizations for debug configurable with compile flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19164003: Make optimizations for debug configurable with compile flag. (Closed)

Created:
7 years, 5 months ago by Michael Achenbach

Modified:
7 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make optimizations for debug configurable with compile flag. To turn on optimizations for debug when building standalone, a compiler flag can be used: make optdebug=on R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15678

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Review. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	Makefile	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

Removed the default change. Now there is just an additional compile flag to enable fast ...

7 years, 5 months ago (2013-07-15 14:12:03 UTC) #2

Jakob Kummerow

LGTM with nit. https://codereview.chromium.org/19164003/diff/3001/Makefile File Makefile (right): https://codereview.chromium.org/19164003/diff/3001/Makefile#newcode94 Makefile:94: # optdebug=on/off nit: just "# optdebug=on"

7 years, 5 months ago (2013-07-15 14:17:59 UTC) #3

Michael Achenbach

7 years, 5 months ago (2013-07-15 16:33:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r15678 (presubmit successful).

Expand Messages | Collapse Messages