Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1916393002: Refactoring to use ArrayVector where applicable (Closed)

Created:
4 years, 8 months ago by Clemens Hammacher
Modified:
4 years, 7 months ago
Reviewers:
titzer, Jarin, rossberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@wasm-offset-table-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactoring to use ArrayVector where applicable It's more readable than the construction Vector<T>(buffer, arraysize(buffer)). All those places are now replaced by ArrayVector(buffer). R=titzer@chromium.org, jarin@chromium.org, rossberg@chromium.org Committed: https://crrev.com/2f1df8a39fef897c1adfa6ce70787361ceb5a567 Cr-Commit-Position: refs/heads/master@{#35843}

Patch Set 1 #

Patch Set 2 : also refactor src/builtins.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -90 lines) Patch
M src/builtins.cc View 1 6 chunks +18 lines, -20 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 15 chunks +35 lines, -43 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 10 chunks +11 lines, -20 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (8 generated)
Clemens Hammacher
If you think this is not reasonable, I am also fine with dropping this CL ...
4 years, 8 months ago (2016-04-26 14:42:38 UTC) #1
titzer
On 2016/04/26 14:42:38, Clemens Hammacher wrote: > If you think this is not reasonable, I ...
4 years, 8 months ago (2016-04-26 14:53:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916393002/1
4 years, 8 months ago (2016-04-27 08:08:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14204)
4 years, 8 months ago (2016-04-27 08:12:18 UTC) #6
Clemens Hammacher
+rossberg for src/parsing +jarin for src/crankshaft
4 years, 8 months ago (2016-04-27 08:23:07 UTC) #9
Jarin
lgtm
4 years, 8 months ago (2016-04-27 08:50:00 UTC) #10
adamk
lgtm for parsing
4 years, 7 months ago (2016-04-27 18:30:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916393002/20001
4 years, 7 months ago (2016-04-28 07:57:14 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 08:00:00 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:48 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f1df8a39fef897c1adfa6ce70787361ceb5a567
Cr-Commit-Position: refs/heads/master@{#35843}

Powered by Google App Engine
This is Rietveld 408576698