Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1916363002: chromium_build_stats: fix trace viewer (Closed)

Created:
4 years, 8 months ago by ukai
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

chromium_build_stats: fix trace viewer generate trace-viewer.html by go generate trace-viewer.html uses <script id="viewer-data" type="text/plain"> for embedded data, instead of "application/json". depends on catapult roll: https://codereview.chromium.org/1921913005/ to generate correct trace-viewer.html BUG=519334, 606663 Committed: https://chromium.googlesource.com/infra/infra/+/ff3c8af68a63bce6eb220f49472997d3162992a6

Patch Set 1 #

Patch Set 2 : don't commit generated file #

Patch Set 3 : split catapult roll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M appengine/chromium_build_stats/README.md View 1 1 chunk +2 lines, -1 line 0 comments Download
M appengine/chromium_build_stats/default/ninja_log.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
D appengine/chromium_build_stats/gen-trace-viewer.sh View 1 1 chunk +0 lines, -13 lines 0 comments Download
M appengine/chromium_build_stats/gopath/src/ninjalog/traceviewer/traceviewer.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916363002/10001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916363002/10001
4 years, 8 months ago (2016-04-26 08:02:16 UTC) #2
ukai
4 years, 8 months ago (2016-04-26 08:04:31 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 08:06:49 UTC) #7
shinyak
lgtm
4 years, 8 months ago (2016-04-26 08:57:53 UTC) #8
Yoshisato Yanagisawa
lgtm
4 years, 8 months ago (2016-04-26 09:05:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916363002/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916363002/30001
4 years, 7 months ago (2016-04-27 04:05:02 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 04:08:41 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/infra/infra/+/ff3c8af68a63bce6eb220f4947299...

Powered by Google App Engine
This is Rietveld 408576698