[debugger] do not expose temporary variables introduced by the parser.

[debugger] do not expose temporary variables introduced by the parser.

R=bmeurer@chromium.org, kozyatinskiy@chromium.org
BUG=chromium:582048
LOG=N

Committed: https://crrev.com/d1e08e7a721f3d5effb0dade0a5c092de47cc9e9
Cr-Commit-Position: refs/heads/master@{#35805}

[Yang, 2016-04-26 06:52:52]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 06:53:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916343002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916343002/1

[Benedikt Meurer, 2016-04-26 06:53:22]

LGTM on ast.

[commit-bot: I haz the power, 2016-04-26 07:20:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 07:20:25]

Dry run: This issue passed the CQ dry run.

[kozy, 2016-04-26 18:05:52]

Can we additionally clear prototype for reported scopeObject when it contains
materialize variables? We'd like to use object as it is reported and for global
and with context we can simple return this object without additional logic but
in case of other objects we've to clear prototype to avoid reporting
Object.prototype values.
Probably we should report only own properties on our side but I'm not sure about
Global and With scopes.

[kozy, 2016-04-26 18:08:11]

FYI: 
https://codereview.chromium.org/1918323002/ it's CL with simplification logic on
our side. I'd like to remove following part:
// Reset scope object prototype to null so that the proto properties
// don't appear in the local scope section.
scopeObject.__proto__ = null;

[Yang, 2016-04-26 18:23:27]

On 2016/04/26 18:08:11, kozyatinskiy wrote:
> FYI: 
> https://codereview.chromium.org/1918323002/ it's CL with simplification logic
on
> our side. I'd like to remove following part:
> // Reset scope object prototype to null so that the proto properties
> // don't appear in the local scope section.
> scopeObject.__proto__ = null;

Do you mean like the object with null proto that we allocate in
debug-evaluate.cc? We can definitely do that.

[Yang, 2016-04-26 18:23:29]

On 2016/04/26 18:08:11, kozyatinskiy wrote:
> FYI: 
> https://codereview.chromium.org/1918323002/ it's CL with simplification logic
on
> our side. I'd like to remove following part:
> // Reset scope object prototype to null so that the proto properties
> // don't appear in the local scope section.
> scopeObject.__proto__ = null;

Do you mean like the object with null proto that we allocate in
debug-evaluate.cc? We can definitely do that.

[kozy, 2016-04-26 18:39:18]

On 2016/04/26 18:23:29, Yang wrote:
> On 2016/04/26 18:08:11, kozyatinskiy wrote:
> > FYI: 
> > https://codereview.chromium.org/1918323002/ it's CL with simplification
logic
> on
> > our side. I'd like to remove following part:
> > // Reset scope object prototype to null so that the proto properties
> > // don't appear in the local scope section.
> > scopeObject.__proto__ = null;
> 
> Do you mean like the object with null proto that we allocate in
> debug-evaluate.cc? We can definitely do that.

Yes, it will work.

[Yang, 2016-04-27 04:43:17]

On 2016/04/26 18:39:18, kozyatinskiy wrote:
> On 2016/04/26 18:23:29, Yang wrote:
> > On 2016/04/26 18:08:11, kozyatinskiy wrote:
> > > FYI: 
> > > https://codereview.chromium.org/1918323002/ it's CL with simplification
> logic
> > on
> > > our side. I'd like to remove following part:
> > > // Reset scope object prototype to null so that the proto properties
> > > // don't appear in the local scope section.
> > > scopeObject.__proto__ = null;
> > 
> > Do you mean like the object with null proto that we allocate in
> > debug-evaluate.cc? We can definitely do that.
> 
> Yes, it will work.

I'll land this first, and prepare a separate patch for the null proto.

[Yang, 2016-04-27 04:43:27]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-04-27 04:43:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916343002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916343002/1

[commit-bot: I haz the power, 2016-04-27 04:48:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-27 04:49:57]

Description was changed from

==========
[debugger] do not expose temporary variables introduced by the parser.

R=bmeurer@chromium.org, kozyatinskiy@chromium.org
BUG=chromium:582048
LOG=N
==========

to

==========
[debugger] do not expose temporary variables introduced by the parser.

R=bmeurer@chromium.org, kozyatinskiy@chromium.org
BUG=chromium:582048
LOG=N

Committed: https://crrev.com/d1e08e7a721f3d5effb0dade0a5c092de47cc9e9
Cr-Commit-Position: refs/heads/master@{#35805}
==========

[commit-bot: I haz the power, 2016-04-27 04:49:58]

Patchset 1 (id:??) landed as
https://crrev.com/d1e08e7a721f3d5effb0dade0a5c092de47cc9e9
Cr-Commit-Position: refs/heads/master@{#35805}