scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_blink_trybot_test_failures.json ('k') | scripts/slave/recipes/chromium_trybot.expected/webkit_tests_interrupted.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json b/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

index 1354118db7bf96e07738bb471526200cc883e8d7..46fabc688679195e753ebcfa310f665b8804a142 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json

@@ -321,6 +321,9 @@

"/path/to/tmp/json"

"cwd": "[SLAVE_BUILD]",

+ "env": {

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json"

+ },

"name": "analyze",

"~followup_annotations": [

"@@@STEP_TEXT@No compile necessary@@@",

@@ -377,6 +380,9 @@

"//out/Release"

"cwd": "[SLAVE_BUILD]",

+ "env": {

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json"

+ },

"name": "generate_build_files (with patch)"

{