scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_aosp_perf_bisect.json ('k') | scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json

diff --git a/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json b/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json

index ab6e63e39fb82111a0267d1c221a4f3d2b4c058a..db5e0050544057b59787b00d76fce9d5cde817e3 100644

--- a/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json

+++ b/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json

@@ -262,6 +262,9 @@

"//out/Release"

"cwd": "[SLAVE_BUILD]",

+ "env": {

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

+ },

"name": "generate_build_files (with patch)"

{

@@ -484,6 +487,9 @@

"//out/Release"

"cwd": "[SLAVE_BUILD]",

+ "env": {

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

+ },

"name": "generate_build_files Without Patch"

{