scripts/slave/recipes/webrtc/ios.expected/gn_build.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/webrtc/ios.expected/gn_build.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/ios/try.expected/gn.json ('k') | scripts/slave/recipes/win_analyze.expected/full_chromium_fyi_Chromium_Windows_Analyze.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "RECIPE_PACKAGE_REPO[build]/scripts/slave/ios/host_info.py",	4 "RECIPE_PACKAGE_REPO[build]/scripts/slave/ios/host_info.py",

5 "--json-file",	5 "--json-file",

6 "/path/to/tmp/json"	6 "/path/to/tmp/json"

7 ],	7 ],

8 "cwd": "[SLAVE_BUILD]",	8 "cwd": "[SLAVE_BUILD]",

9 "name": "host and tools info",	9 "name": "host and tools info",

10 "~followup_annotations": [	10 "~followup_annotations": [

(...skipping 187 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
198 "chromium.fake",	198 "chromium.fake",

199 "-b",	199 "-b",

200 "ios",	200 "ios",

201 "--config-file",	201 "--config-file",

202 "[SLAVE_BUILD]/src/webrtc/build/mb_config.pyl",	202 "[SLAVE_BUILD]/src/webrtc/build/mb_config.pyl",

203 "--goma-dir",	203 "--goma-dir",

204 "[CACHE]/cipd/goma",	204 "[CACHE]/cipd/goma",

205 "//out/Debug-iphoneos"	205 "//out/Debug-iphoneos"

206 ],	206 ],

207 "cwd": "[SLAVE_BUILD]",	207 "cwd": "[SLAVE_BUILD]",

	208 "env": {

	209 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

	210 },

208 "name": "generate_build_files"	211 "name": "generate_build_files"

209 },	212 },

210 {	213 {

211 "cmd": [	214 "cmd": [

212 "ninja",	215 "ninja",

213 "-C",	216 "-C",

214 "[SLAVE_BUILD]/src/out/Debug-iphoneos"	217 "[SLAVE_BUILD]/src/out/Debug-iphoneos"

215 ],	218 ],

216 "cwd": "[SLAVE_BUILD]/src/out/Debug-iphoneos",	219 "cwd": "[SLAVE_BUILD]/src/out/Debug-iphoneos",

217 "name": "compile"	220 "name": "compile"

218 },	221 },

219 {	222 {

220 "name": "$result",	223 "name": "$result",

221 "recipe_result": null,	224 "recipe_result": null,

222 "status_code": 0	225 "status_code": 0

223 }	226 }

224 ]	227 ]

OLD	NEW