scripts/slave/recipes/ios/try.expected/gn.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/ios/try.expected/gn.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json ('k') | scripts/slave/recipes/webrtc/ios.expected/gn_build.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "RECIPE_PACKAGE_REPO[build]/scripts/slave/ios/host_info.py",	4 "RECIPE_PACKAGE_REPO[build]/scripts/slave/ios/host_info.py",

5 "--json-file",	5 "--json-file",

6 "/path/to/tmp/json"	6 "/path/to/tmp/json"

7 ],	7 ],

8 "cwd": "[SLAVE_BUILD]",	8 "cwd": "[SLAVE_BUILD]",

9 "name": "host and tools info",	9 "name": "host and tools info",

10 "~followup_annotations": [	10 "~followup_annotations": [

(...skipping 259 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
270 "tryserver.fake",	270 "tryserver.fake",

271 "-b",	271 "-b",

272 "ios",	272 "ios",

273 "--config-file",	273 "--config-file",

274 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",	274 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",

275 "--goma-dir",	275 "--goma-dir",

276 "[CACHE]/cipd/goma",	276 "[CACHE]/cipd/goma",

277 "//out/Debug-iphonesimulator"	277 "//out/Debug-iphonesimulator"

278 ],	278 ],

279 "cwd": "[SLAVE_BUILD]",	279 "cwd": "[SLAVE_BUILD]",

	280 "env": {

	281 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

	282 },

280 "name": "generate_build_files (with patch)"	283 "name": "generate_build_files (with patch)"

281 },	284 },

282 {	285 {

283 "cmd": [	286 "cmd": [

284 "git",	287 "git",

285 "diff",	288 "diff",

286 "--cached",	289 "--cached",

287 "--name-only"	290 "--name-only"

288 ],	291 ],

289 "cwd": "[SLAVE_BUILD]/src",	292 "cwd": "[SLAVE_BUILD]/src",

(...skipping 167 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
457 "@@@STEP_LOG_END@fake log@@@",	460 "@@@STEP_LOG_END@fake log@@@",

458 "@@@STEP_LINK@fake URL text@fake URL@@@"	461 "@@@STEP_LINK@fake URL text@fake URL@@@"

459 ]	462 ]

460 },	463 },

461 {	464 {

462 "name": "$result",	465 "name": "$result",

463 "recipe_result": null,	466 "recipe_result": null,

464 "status_code": 0	467 "status_code": 0

465 }	468 }

466 ]	469 ]

OLD	NEW