scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/script_test_with_overridden_compile_targets.json ('k') | scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "tryserver.chromium.linux",	8 "tryserver.chromium.linux",

9 "--builder",	9 "--builder",

10 "linux_chromium_rel_ng",	10 "linux_chromium_rel_ng",

(...skipping 323 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
334 "tryserver.chromium.linux",	334 "tryserver.chromium.linux",

335 "-b",	335 "-b",

336 "linux_chromium_rel_ng",	336 "linux_chromium_rel_ng",

337 "--config-file",	337 "--config-file",

338 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",	338 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",

339 "--goma-dir",	339 "--goma-dir",

340 "[CACHE]/cipd/goma",	340 "[CACHE]/cipd/goma",

341 "//out/Release"	341 "//out/Release"

342 ],	342 ],

343 "cwd": "[SLAVE_BUILD]",	343 "cwd": "[SLAVE_BUILD]",

	344 "env": {

	345 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

	346 },

344 "name": "generate_build_files (with patch)"	347 "name": "generate_build_files (with patch)"

345 },	348 },

346 {	349 {

347 "cmd": [	350 "cmd": [

348 "python",	351 "python",

349 "-u",	352 "-u",

350 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",	353 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",

351 "--show-path",	354 "--show-path",

352 "python",	355 "python",

353 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",	356 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
395 ],	398 ],

396 "cwd": "[SLAVE_BUILD]",	399 "cwd": "[SLAVE_BUILD]",

397 "name": "mark: before_tests"	400 "name": "mark: before_tests"

398 },	401 },

399 {	402 {

400 "name": "$result",	403 "name": "$result",

401 "recipe_result": null,	404 "recipe_result": null,

402 "status_code": 0	405 "status_code": 0

403 }	406 }

404 ]	407 ]

OLD	NEW