scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel_ng.json ('k') | scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_dbg.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"	6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"

7 ],	7 ],

8 "cwd": "[SLAVE_BUILD]",	8 "cwd": "[SLAVE_BUILD]",

9 "name": "taskkill"	9 "name": "taskkill"

10 },	10 },

(...skipping 332 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
343 "tryserver.chromium.win",	343 "tryserver.chromium.win",

344 "-b",	344 "-b",

345 "win_clang",	345 "win_clang",

346 "--config-file",	346 "--config-file",

347 "[SLAVE_BUILD]\\src\\tools\\mb\\mb_config.pyl",	347 "[SLAVE_BUILD]\\src\\tools\\mb\\mb_config.pyl",

348 "--goma-dir",	348 "--goma-dir",

349 "[CACHE]\\cipd\\goma",	349 "[CACHE]\\cipd\\goma",

350 "//out/Debug_x64"	350 "//out/Debug_x64"

351 ],	351 ],

352 "cwd": "[SLAVE_BUILD]",	352 "cwd": "[SLAVE_BUILD]",

	353 "env": {

	354 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-ac count-goma-client.json"

	355 },

353 "name": "generate_build_files (with patch)"	356 "name": "generate_build_files (with patch)"

354 },	357 },

355 {	358 {

356 "allow_subannotations": true,	359 "allow_subannotations": true,

357 "cmd": [	360 "cmd": [

358 "python",	361 "python",

359 "-u",	362 "-u",

360 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\clang_revision.py",	363 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\clang_revision.py",

361 "--src-dir",	364 "--src-dir",

362 "[SLAVE_BUILD]\\src",	365 "[SLAVE_BUILD]\\src",

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
426 ],	429 ],

427 "cwd": "[SLAVE_BUILD]",	430 "cwd": "[SLAVE_BUILD]",

428 "name": "mark: before_tests"	431 "name": "mark: before_tests"

429 },	432 },

430 {	433 {

431 "name": "$result",	434 "name": "$result",

432 "recipe_result": null,	435 "recipe_result": null,

433 "status_code": 0	436 "status_code": 0

434 }	437 }

435 ]	438 ]

OLD	NEW