scripts/slave/recipes/chromium.expected/full_client_v8_fyi_V8_Linux_GN.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/full_client_v8_fyi_V8_Linux_GN.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_client_v8_fyi_V8_Android_GN__dbg_.json ('k') | scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_linux_fyi_perf_bisect.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "client.v8.fyi",	8 "client.v8.fyi",

9 "--builder",	9 "--builder",

10 "V8 Linux GN",	10 "V8 Linux GN",

(...skipping 222 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
233 "client.v8.fyi",	233 "client.v8.fyi",

234 "-b",	234 "-b",

235 "V8 Linux GN",	235 "V8 Linux GN",

236 "--config-file",	236 "--config-file",

237 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",	237 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",

238 "--goma-dir",	238 "--goma-dir",

239 "[CACHE]/cipd/goma",	239 "[CACHE]/cipd/goma",

240 "//out/Release"	240 "//out/Release"

241 ],	241 ],

242 "cwd": "[SLAVE_BUILD]",	242 "cwd": "[SLAVE_BUILD]",

	243 "env": {

	244 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

	245 },

243 "name": "generate_build_files"	246 "name": "generate_build_files"

244 },	247 },

245 {	248 {

246 "cmd": [	249 "cmd": [

247 "python",	250 "python",

248 "-u",	251 "-u",

249 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",	252 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",

250 "--show-path",	253 "--show-path",

251 "python",	254 "python",

252 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",	255 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",

(...skipping 61 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
314 ],	317 ],

315 "cwd": "[SLAVE_BUILD]",	318 "cwd": "[SLAVE_BUILD]",

316 "name": "package build"	319 "name": "package build"

317 },	320 },

318 {	321 {

319 "name": "$result",	322 "name": "$result",

320 "recipe_result": null,	323 "recipe_result": null,

321 "status_code": 0	324 "status_code": 0

322 }	325 }

323 ]	326 ]

OLD	NEW