scripts/slave/recipes/chromium.expected/full_chromium_win_WinClang64__dbg_.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/full_chromium_win_WinClang64__dbg_.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GN__dbg_.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"	6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"

7 ],	7 ],

8 "cwd": "[SLAVE_BUILD]",	8 "cwd": "[SLAVE_BUILD]",

9 "name": "taskkill"	9 "name": "taskkill"

10 },	10 },

(...skipping 252 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
263 "chromium.win",	263 "chromium.win",

264 "-b",	264 "-b",

265 "WinClang64 (dbg)",	265 "WinClang64 (dbg)",

266 "--config-file",	266 "--config-file",

267 "[SLAVE_BUILD]\\src\\tools\\mb\\mb_config.pyl",	267 "[SLAVE_BUILD]\\src\\tools\\mb\\mb_config.pyl",

268 "--goma-dir",	268 "--goma-dir",

269 "[CACHE]\\cipd\\goma",	269 "[CACHE]\\cipd\\goma",

270 "//out/Debug_x64"	270 "//out/Debug_x64"

271 ],	271 ],

272 "cwd": "[SLAVE_BUILD]",	272 "cwd": "[SLAVE_BUILD]",

	273 "env": {

	274 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-ac count-goma-client.json"

	275 },

273 "name": "generate_build_files"	276 "name": "generate_build_files"

274 },	277 },

275 {	278 {

276 "allow_subannotations": true,	279 "allow_subannotations": true,

277 "cmd": [	280 "cmd": [

278 "python",	281 "python",

279 "-u",	282 "-u",

280 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\clang_revision.py",	283 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\clang_revision.py",

281 "--src-dir",	284 "--src-dir",

282 "[SLAVE_BUILD]\\src",	285 "[SLAVE_BUILD]\\src",

(...skipping 77 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
360 ],	363 ],

361 "cwd": "[SLAVE_BUILD]",	364 "cwd": "[SLAVE_BUILD]",

362 "name": "package build"	365 "name": "package build"

363 },	366 },

364 {	367 {

365 "name": "$result",	368 "name": "$result",

366 "recipe_result": null,	369 "recipe_result": null,

367 "status_code": 0	370 "status_code": 0

368 }	371 }

369 ]	372 ]

OLD	NEW