scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_GN.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_GN.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_GN__dbg_.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_GN__dbg_.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "chromium.webrtc.fyi",	8 "chromium.webrtc.fyi",

9 "--builder",	9 "--builder",

10 "Mac GN",	10 "Mac GN",

(...skipping 280 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
291 "Mac GN",	291 "Mac GN",

292 "--config-file",	292 "--config-file",

293 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",	293 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",

294 "--goma-dir",	294 "--goma-dir",

295 "[CACHE]/cipd/goma",	295 "[CACHE]/cipd/goma",

296 "--swarming-targets-file",	296 "--swarming-targets-file",

297 "browser_tests\n",	297 "browser_tests\n",

298 "//out/Release"	298 "//out/Release"

299 ],	299 ],

300 "cwd": "[SLAVE_BUILD]",	300 "cwd": "[SLAVE_BUILD]",

	301 "env": {

	302 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

	303 },

301 "name": "generate_build_files",	304 "name": "generate_build_files",

302 "~followup_annotations": [	305 "~followup_annotations": [

303 "@@@STEP_LOG_LINE@swarming-targets-file.txt@browser_tests@@@",	306 "@@@STEP_LOG_LINE@swarming-targets-file.txt@browser_tests@@@",

304 "@@@STEP_LOG_END@swarming-targets-file.txt@@@"	307 "@@@STEP_LOG_END@swarming-targets-file.txt@@@"

305 ]	308 ]

306 },	309 },

307 {	310 {

308 "allow_subannotations": true,	311 "allow_subannotations": true,

309 "cmd": [	312 "cmd": [

310 "python",	313 "python",

(...skipping 150 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
461 "@@@STEP_LOG_LINE@python.inline@sys.exit(1)@@@",	464 "@@@STEP_LOG_LINE@python.inline@sys.exit(1)@@@",

462 "@@@STEP_LOG_END@python.inline@@@"	465 "@@@STEP_LOG_END@python.inline@@@"

463 ]	466 ]

464 },	467 },

465 {	468 {

466 "name": "$result",	469 "name": "$result",

467 "recipe_result": null,	470 "recipe_result": null,

468 "status_code": 0	471 "status_code": 0

469 }	472 }

470 ]	473 ]

OLD	NEW