scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_GN.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_GN.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win_x64_Builder__dbg_.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_GN__dbg_.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "chromium.webrtc.fyi",	8 "chromium.webrtc.fyi",

9 "--builder",	9 "--builder",

10 "Android GN",	10 "Android GN",

(...skipping 280 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
291 "chromium.webrtc.fyi",	291 "chromium.webrtc.fyi",

292 "-b",	292 "-b",

293 "Android GN",	293 "Android GN",

294 "--config-file",	294 "--config-file",

295 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",	295 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",

296 "--goma-dir",	296 "--goma-dir",

297 "[CACHE]/cipd/goma",	297 "[CACHE]/cipd/goma",

298 "//out/Release"	298 "//out/Release"

299 ],	299 ],

300 "cwd": "[SLAVE_BUILD]",	300 "cwd": "[SLAVE_BUILD]",

	301 "env": {

	302 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

	303 },

301 "name": "generate_build_files"	304 "name": "generate_build_files"

302 },	305 },

303 {	306 {

304 "cmd": [	307 "cmd": [

305 "python",	308 "python",

306 "-u",	309 "-u",

307 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",	310 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",

308 "--show-path",	311 "--show-path",

309 "python",	312 "python",

310 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",	313 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
342 "@@@STEP_LOG_LINE@json.output (invalid)@null@@@",	345 "@@@STEP_LOG_LINE@json.output (invalid)@null@@@",

343 "@@@STEP_LOG_END@json.output (invalid)@@@"	346 "@@@STEP_LOG_END@json.output (invalid)@@@"

344 ]	347 ]

345 },	348 },

346 {	349 {

347 "name": "$result",	350 "name": "$result",

348 "recipe_result": null,	351 "recipe_result": null,

349 "status_code": 0	352 "status_code": 0

350 }	353 }

351 ]	354 ]

OLD	NEW