scripts/slave/recipes/chromium.expected/full_chromium_webkit_Android_Builder.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/full_chromium_webkit_Android_Builder.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_x64_Builder.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "chromium.webkit",	8 "chromium.webkit",

9 "--builder",	9 "--builder",

10 "Android Builder",	10 "Android Builder",

(...skipping 261 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
272 "chromium.webkit",	272 "chromium.webkit",

273 "-b",	273 "-b",

274 "Android Builder",	274 "Android Builder",

275 "--config-file",	275 "--config-file",

276 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",	276 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",

277 "--goma-dir",	277 "--goma-dir",

278 "[CACHE]/cipd/goma",	278 "[CACHE]/cipd/goma",

279 "//out/Release"	279 "//out/Release"

280 ],	280 ],

281 "cwd": "[SLAVE_BUILD]",	281 "cwd": "[SLAVE_BUILD]",

	282 "env": {

	283 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

	284 },

282 "name": "generate_build_files"	285 "name": "generate_build_files"

283 },	286 },

284 {	287 {

285 "cmd": [	288 "cmd": [

286 "python",	289 "python",

287 "-u",	290 "-u",

288 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",	291 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",

289 "--show-path",	292 "--show-path",

290 "python",	293 "python",

291 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",	294 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",

(...skipping 86 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
378 "~followup_annotations": [	381 "~followup_annotations": [

379 "@@@STEP_TEXT@WebKit Android (Nexus4)@@@"	382 "@@@STEP_TEXT@WebKit Android (Nexus4)@@@"

380 ]	383 ]

381 },	384 },

382 {	385 {

383 "name": "$result",	386 "name": "$result",

384 "recipe_result": null,	387 "recipe_result": null,

385 "status_code": 0	388 "status_code": 0

386 }	389 }

387 ]	390 ]

OLD	NEW