scripts/slave/recipes/chromium.expected/full_chromium_perf_Mac_Builder.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/full_chromium_perf_Mac_Builder.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_perf_Linux_Builder.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_Builder.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "chromium.perf",	8 "chromium.perf",

9 "--builder",	9 "--builder",

10 "Mac Builder",	10 "Mac Builder",

(...skipping 181 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
192 "chromium.perf",	192 "chromium.perf",

193 "-b",	193 "-b",

194 "Mac Builder",	194 "Mac Builder",

195 "--config-file",	195 "--config-file",

196 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",	196 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",

197 "--goma-dir",	197 "--goma-dir",

198 "[CACHE]/cipd/goma",	198 "[CACHE]/cipd/goma",

199 "//out/Release"	199 "//out/Release"

200 ],	200 ],

201 "cwd": "[SLAVE_BUILD]",	201 "cwd": "[SLAVE_BUILD]",

	202 "env": {

	203 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

	204 },

202 "name": "generate_build_files"	205 "name": "generate_build_files"

203 },	206 },

204 {	207 {

205 "allow_subannotations": true,	208 "allow_subannotations": true,

206 "cmd": [	209 "cmd": [

207 "python",	210 "python",

208 "-u",	211 "-u",

209 "RECIPE_PACKAGE_REPO[build]/scripts/slave/clang_revision.py",	212 "RECIPE_PACKAGE_REPO[build]/scripts/slave/clang_revision.py",

210 "--src-dir",	213 "--src-dir",

211 "[SLAVE_BUILD]/src",	214 "[SLAVE_BUILD]/src",

(...skipping 621 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
833 "~followup_annotations": [	836 "~followup_annotations": [

834 "@@@STEP_TEXT@Mac Retina Perf (5)@@@"	837 "@@@STEP_TEXT@Mac Retina Perf (5)@@@"

835 ]	838 ]

836 },	839 },

837 {	840 {

838 "name": "$result",	841 "name": "$result",

839 "recipe_result": null,	842 "recipe_result": null,

840 "status_code": 0	843 "status_code": 0

841 }	844 }

842 ]	845 ]

OLD	NEW