scripts/slave/recipes/chromium.expected/full_chromium_mojo_Chromium_Mojo_Android.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/full_chromium_mojo_Chromium_Mojo_Android.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Chromium_Linux_TSan_Builder.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_mojo_Chromium_Mojo_Linux.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "chromium.mojo",	8 "chromium.mojo",

9 "--builder",	9 "--builder",

10 "Chromium Mojo Android",	10 "Chromium Mojo Android",

(...skipping 258 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
269 "chromium.mojo",	269 "chromium.mojo",

270 "-b",	270 "-b",

271 "Chromium Mojo Android",	271 "Chromium Mojo Android",

272 "--config-file",	272 "--config-file",

273 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",	273 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",

274 "--goma-dir",	274 "--goma-dir",

275 "[CACHE]/cipd/goma",	275 "[CACHE]/cipd/goma",

276 "//out/Release"	276 "//out/Release"

277 ],	277 ],

278 "cwd": "[SLAVE_BUILD]",	278 "cwd": "[SLAVE_BUILD]",

	279 "env": {

	280 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

	281 },

279 "name": "generate_build_files"	282 "name": "generate_build_files"

280 },	283 },

281 {	284 {

282 "cmd": [	285 "cmd": [

283 "python",	286 "python",

284 "-u",	287 "-u",

285 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",	288 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",

286 "--show-path",	289 "--show-path",

287 "python",	290 "python",

288 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",	291 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
320 "@@@STEP_LOG_LINE@json.output (invalid)@null@@@",	323 "@@@STEP_LOG_LINE@json.output (invalid)@null@@@",

321 "@@@STEP_LOG_END@json.output (invalid)@@@"	324 "@@@STEP_LOG_END@json.output (invalid)@@@"

322 ]	325 ]

323 },	326 },

324 {	327 {

325 "name": "$result",	328 "name": "$result",

326 "recipe_result": null,	329 "recipe_result": null,

327 "status_code": 0	330 "status_code": 0

328 }	331 }

329 ]	332 ]

OLD	NEW