scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_lkgr_Win_SyzyASAN_LKGR.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder__dbg_.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "chromium.mac",	8 "chromium.mac",

9 "--builder",	9 "--builder",

10 "Mac Builder",	10 "Mac Builder",

(...skipping 279 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
290 "Mac Builder",	290 "Mac Builder",

291 "--config-file",	291 "--config-file",

292 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",	292 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",

293 "--goma-dir",	293 "--goma-dir",

294 "[CACHE]/cipd/goma",	294 "[CACHE]/cipd/goma",

295 "--swarming-targets-file",	295 "--swarming-targets-file",

296 "browser_tests\n",	296 "browser_tests\n",

297 "//out/Release"	297 "//out/Release"

298 ],	298 ],

299 "cwd": "[SLAVE_BUILD]",	299 "cwd": "[SLAVE_BUILD]",

	300 "env": {

	301 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

	302 },

300 "name": "generate_build_files",	303 "name": "generate_build_files",

301 "~followup_annotations": [	304 "~followup_annotations": [

302 "@@@STEP_LOG_LINE@swarming-targets-file.txt@browser_tests@@@",	305 "@@@STEP_LOG_LINE@swarming-targets-file.txt@browser_tests@@@",

303 "@@@STEP_LOG_END@swarming-targets-file.txt@@@"	306 "@@@STEP_LOG_END@swarming-targets-file.txt@@@"

304 ]	307 ]

305 },	308 },

306 {	309 {

307 "allow_subannotations": true,	310 "allow_subannotations": true,

308 "cmd": [	311 "cmd": [

309 "python",	312 "python",

(...skipping 201 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
511 "~followup_annotations": [	514 "~followup_annotations": [

512 "@@@STEP_TEXT@Mac10.9 Tests@@@"	515 "@@@STEP_TEXT@Mac10.9 Tests@@@"

513 ]	516 ]

514 },	517 },

515 {	518 {

516 "name": "$result",	519 "name": "$result",

517 "recipe_result": null,	520 "recipe_result": null,

518 "status_code": 0	521 "status_code": 0

519 }	522 }

520 ]	523 ]

OLD	NEW