scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux_Goma_Canary.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux_Goma_Canary.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux32_Goma_Canary__clobber_.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux_Goma_Canary__clobber_.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",	6 "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",

7 "sync",	7 "sync",

8 "--verbose",	8 "--verbose",

9 "--force",	9 "--force",

10 "--revision",	10 "--revision",

(...skipping 236 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
247 "chromium.fyi",	247 "chromium.fyi",

248 "-b",	248 "-b",

249 "Chromium Linux Goma Canary",	249 "Chromium Linux Goma Canary",

250 "--config-file",	250 "--config-file",

251 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",	251 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",

252 "--goma-dir",	252 "--goma-dir",

253 "[CACHE]/cipd/goma",	253 "[CACHE]/cipd/goma",

254 "//out/Release"	254 "//out/Release"

255 ],	255 ],

256 "cwd": "[SLAVE_BUILD]",	256 "cwd": "[SLAVE_BUILD]",

	257 "env": {

	258 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

	259 },

257 "name": "generate_build_files"	260 "name": "generate_build_files"

258 },	261 },

259 {	262 {

260 "cmd": [	263 "cmd": [

261 "python",	264 "python",

262 "-u",	265 "-u",

263 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",	266 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",

264 "--show-path",	267 "--show-path",

265 "python",	268 "python",

266 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",	269 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",

(...skipping 88 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
355 ],	358 ],

356 "cwd": "[SLAVE_BUILD]",	359 "cwd": "[SLAVE_BUILD]",

357 "name": "content_unittests"	360 "name": "content_unittests"

358 },	361 },

359 {	362 {

360 "name": "$result",	363 "name": "$result",

361 "recipe_result": null,	364 "recipe_result": null,

362 "status_code": 0	365 "status_code": 0

363 }	366 }

364 ]	367 ]

OLD	NEW