scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Full.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Full.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder__dbg_.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_GN.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "chromium.chromiumos",	8 "chromium.chromiumos",

9 "--builder",	9 "--builder",

10 "Linux ChromiumOS Full",	10 "Linux ChromiumOS Full",

(...skipping 220 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
231 "chromium.chromiumos",	231 "chromium.chromiumos",

232 "-b",	232 "-b",

233 "Linux ChromiumOS Full",	233 "Linux ChromiumOS Full",

234 "--config-file",	234 "--config-file",

235 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",	235 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",

236 "--goma-dir",	236 "--goma-dir",

237 "[CACHE]/cipd/goma",	237 "[CACHE]/cipd/goma",

238 "//out/Release"	238 "//out/Release"

239 ],	239 ],

240 "cwd": "[SLAVE_BUILD]",	240 "cwd": "[SLAVE_BUILD]",

	241 "env": {

	242 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

	243 },

241 "name": "generate_build_files"	244 "name": "generate_build_files"

242 },	245 },

243 {	246 {

244 "cmd": [	247 "cmd": [

245 "python",	248 "python",

246 "-u",	249 "-u",

247 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",	250 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",

248 "--show-path",	251 "--show-path",

249 "python",	252 "python",

250 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",	253 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",

(...skipping 79 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
330 ],	333 ],

331 "cwd": "[SLAVE_BUILD]",	334 "cwd": "[SLAVE_BUILD]",

332 "name": "archive build"	335 "name": "archive build"

333 },	336 },

334 {	337 {

335 "name": "$result",	338 "name": "$result",

336 "recipe_result": null,	339 "recipe_result": null,

337 "status_code": 0	340 "status_code": 0

338 }	341 }

339 ]	342 ]

OLD	NEW