scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Mac.json - Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Mac.json

Issue 1916303006: Fix GOMA_SERVICE_ACCOUNT_JSON_FILE propagation in mb. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: make sure GOMA_SERVICE_ACCOUNT_JSON_FILE is present in generate_build_files, too Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "chromium.chrome",	8 "chromium.chrome",

9 "--builder",	9 "--builder",

10 "Google Chrome Mac",	10 "Google Chrome Mac",

(...skipping 219 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
230 "chromium.chrome",	230 "chromium.chrome",

231 "-b",	231 "-b",

232 "Google Chrome Mac",	232 "Google Chrome Mac",

233 "--config-file",	233 "--config-file",

234 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",	234 "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",

235 "--goma-dir",	235 "--goma-dir",

236 "[CACHE]/cipd/goma",	236 "[CACHE]/cipd/goma",

237 "//out/Release"	237 "//out/Release"

238 ],	238 ],

239 "cwd": "[SLAVE_BUILD]",	239 "cwd": "[SLAVE_BUILD]",

	240 "env": {

	241 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

	242 },

240 "name": "generate_build_files"	243 "name": "generate_build_files"

241 },	244 },

242 {	245 {

243 "allow_subannotations": true,	246 "allow_subannotations": true,

244 "cmd": [	247 "cmd": [

245 "python",	248 "python",

246 "-u",	249 "-u",

247 "RECIPE_PACKAGE_REPO[build]/scripts/slave/clang_revision.py",	250 "RECIPE_PACKAGE_REPO[build]/scripts/slave/clang_revision.py",

248 "--src-dir",	251 "--src-dir",

249 "[SLAVE_BUILD]/src",	252 "[SLAVE_BUILD]/src",

(...skipping 89 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
339 ],	342 ],

340 "cwd": "[SLAVE_BUILD]",	343 "cwd": "[SLAVE_BUILD]",

341 "name": "sizes"	344 "name": "sizes"

342 },	345 },

343 {	346 {

344 "name": "$result",	347 "name": "$result",

345 "recipe_result": null,	348 "recipe_result": null,

346 "status_code": 0	349 "status_code": 0

347 }	350 }

348 ]	351 ]

OLD	NEW