CFX_ByteString::Reserve(), ReleaseBuffer() fixes.

CFX_ByteString::Reserve(), ReleaseBuffer() fixes.

Also identical fixes for CFX_WideString.

Reserve() on an empty string would not actually reserve a
buffer.  Currently unused, but there are places where this
would really help.

ReleaseBuffer() would rarely return memory to the system, since
it would short-circuit thinking it could operate in place.  Tune
the algorithm slightly so that we hold on when the savings is
small.

Bounds check release buffer args rather than just asserting.
Add tests for all of these.

Committed: https://pdfium.googlesource.com/pdfium/+/518fd4c5ababbfbf28e010a9c27098e8f6669e4b

[Tom Sepez, 2016-04-26 17:59:06]

Description was changed from

==========
CFX_ByteString::Reserve(), ReleaseBuffer() fixes.

Reserve() on an empty string would not actually reserve a
buffer.  Currently unused, but there are places where this
would really help.

ReleaseBuffer() would rarely return memory to the system, since
it would short-ciruit thinking it could operate in place.  Tune
the algorithm slightly so that we hold on when the savings is
small.

Add tests for all of these.
==========

to

==========
CFX_ByteString::Reserve(), ReleaseBuffer() fixes.

Also identical fixes for CFX_WideString.

Reserve() on an empty string would not actually reserve a
buffer.  Currently unused, but there are places where this
would really help.

ReleaseBuffer() would rarely return memory to the system, since
it would short-ciruit thinking it could operate in place.  Tune
the algorithm slightly so that we hold on when the savings is
small.

Add tests for all of these.
==========

[Tom Sepez, 2016-04-26 18:19:36]

Description was changed from

==========
CFX_ByteString::Reserve(), ReleaseBuffer() fixes.

Also identical fixes for CFX_WideString.

Reserve() on an empty string would not actually reserve a
buffer.  Currently unused, but there are places where this
would really help.

ReleaseBuffer() would rarely return memory to the system, since
it would short-ciruit thinking it could operate in place.  Tune
the algorithm slightly so that we hold on when the savings is
small.

Add tests for all of these.
==========

to

==========
CFX_ByteString::Reserve(), ReleaseBuffer() fixes.

Also identical fixes for CFX_WideString.

Reserve() on an empty string would not actually reserve a
buffer.  Currently unused, but there are places where this
would really help.

ReleaseBuffer() would rarely return memory to the system, since
it would short-ciruit thinking it could operate in place.  Tune
the algorithm slightly so that we hold on when the savings is
small.

Bounds check release buffer args rather than just asserting.
Add tests for all of these.
==========

[Tom Sepez, 2016-04-26 18:19:37]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-26 18:20:03]

Lei, I think the lesson is never write your own STL replacement.

[Lei Zhang, 2016-04-26 18:51:12]

lgtm

https://codereview.chromium.org/1916303004/diff/20001/core/fxcrt/fx_basic_wst...
File core/fxcrt/fx_basic_wstring_unittest.cpp (right):

https://codereview.chromium.org/1916303004/diff/20001/core/fxcrt/fx_basic_wst...
core/fxcrt/fx_basic_wstring_unittest.cpp:608: str.TrimLeft();
The bytestring version doesn't have this. Intentional?

[Tom Sepez, 2016-04-26 18:54:59]

Description was changed from

==========
CFX_ByteString::Reserve(), ReleaseBuffer() fixes.

Also identical fixes for CFX_WideString.

Reserve() on an empty string would not actually reserve a
buffer.  Currently unused, but there are places where this
would really help.

ReleaseBuffer() would rarely return memory to the system, since
it would short-ciruit thinking it could operate in place.  Tune
the algorithm slightly so that we hold on when the savings is
small.

Bounds check release buffer args rather than just asserting.
Add tests for all of these.
==========

to

==========
CFX_ByteString::Reserve(), ReleaseBuffer() fixes.

Also identical fixes for CFX_WideString.

Reserve() on an empty string would not actually reserve a
buffer.  Currently unused, but there are places where this
would really help.

ReleaseBuffer() would rarely return memory to the system, since
it would short-circuit thinking it could operate in place.  Tune
the algorithm slightly so that we hold on when the savings is
small.

Bounds check release buffer args rather than just asserting.
Add tests for all of these.
==========

[Tom Sepez, 2016-04-26 18:57:11]

https://codereview.chromium.org/1916303004/diff/20001/core/fxcrt/fx_basic_wst...
File core/fxcrt/fx_basic_wstring_unittest.cpp (right):

https://codereview.chromium.org/1916303004/diff/20001/core/fxcrt/fx_basic_wst...
core/fxcrt/fx_basic_wstring_unittest.cpp:608: str.TrimLeft();
On 2016/04/26 18:51:12, Lei Zhang wrote:
> The bytestring version doesn't have this. Intentional?

Argh, cut n paste fail.

[Tom Sepez, 2016-04-26 18:58:38]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-26 18:58:38]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1916303004/#ps40001
(title: "Remove stray TrimLeft()")

[commit-bot: I haz the power, 2016-04-26 18:58:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916303004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916303004/40001

[commit-bot: I haz the power, 2016-04-26 19:13:19]

Description was changed from

==========
CFX_ByteString::Reserve(), ReleaseBuffer() fixes.

Also identical fixes for CFX_WideString.

Reserve() on an empty string would not actually reserve a
buffer.  Currently unused, but there are places where this
would really help.

ReleaseBuffer() would rarely return memory to the system, since
it would short-circuit thinking it could operate in place.  Tune
the algorithm slightly so that we hold on when the savings is
small.

Bounds check release buffer args rather than just asserting.
Add tests for all of these.
==========

to

==========
CFX_ByteString::Reserve(), ReleaseBuffer() fixes.

Also identical fixes for CFX_WideString.

Reserve() on an empty string would not actually reserve a
buffer.  Currently unused, but there are places where this
would really help.

ReleaseBuffer() would rarely return memory to the system, since
it would short-circuit thinking it could operate in place.  Tune
the algorithm slightly so that we hold on when the savings is
small.

Bounds check release buffer args rather than just asserting.
Add tests for all of these.

Committed:
https://pdfium.googlesource.com/pdfium/+/518fd4c5ababbfbf28e010a9c27098e8f666...
==========

[commit-bot: I haz the power, 2016-04-26 19:13:20]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/518fd4c5ababbfbf28e010a9c27098e8f666...