cc/output/program_binding.cc - Issue 1916303003: Report lost context from GLES2Implementation based on share group state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/program_binding.cc

Issue 1916303003: Report lost context from GLES2Implementation based on share group state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lost-share-group: disconnect-channel Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/program_binding.cc

diff --git a/cc/output/program_binding.cc b/cc/output/program_binding.cc

index c05447c7d65037c762a8bd590af50919be6e0910..7f6bf17e0649fbc35a8554780139fac5f5b61852 100644

--- a/cc/output/program_binding.cc

+++ b/cc/output/program_binding.cc

@@ -88,7 +88,7 @@ unsigned ProgramBindingBase::LoadShader(GLES2Interface* context,

shader_source_str,

shader_length);

context->CompileShader(shader);

-#ifndef NDEBUG

+#if DCHECK_IS_ON()

int compiled = 0;

context->GetShaderiv(shader, GL_COMPILE_STATUS, &compiled);

if (!compiled)

« no previous file with comments | « cc/output/gl_renderer_unittest.cc ('k') | components/mus/gles2/command_buffer_local.h » ('j') | no next file with comments »