Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1916243002: Fix getSourceReport's forceCompile option for unused classes. (Closed)

Created:
4 years, 8 months ago by turnidge
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix getSourceReport's forceCompile option for unused classes. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/956ac4c18331824ed140d27d2b1ca5fa03f22c1b

Patch Set 1 #

Total comments: 1

Patch Set 2 : Report compilation errors #

Total comments: 3

Patch Set 3 : code review #

Patch Set 4 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -8 lines) Patch
M runtime/observatory/tests/service/get_version_rpc_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service/service.md View 1 5 chunks +9 lines, -4 lines 0 comments Download
M runtime/vm/source_report.cc View 1 2 chunks +37 lines, -2 lines 0 comments Download
M runtime/vm/source_report_test.cc View 1 2 3 1 chunk +134 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
turnidge
4 years, 8 months ago (2016-04-25 22:55:53 UTC) #2
rmacnak
https://codereview.chromium.org/1916243002/diff/1/runtime/vm/source_report.cc File runtime/vm/source_report.cc (right): https://codereview.chromium.org/1916243002/diff/1/runtime/vm/source_report.cc#newcode404 runtime/vm/source_report.cc:404: // This class will get an error when finalized. ...
4 years, 8 months ago (2016-04-25 23:28:34 UTC) #3
turnidge
PTAL I have added reporting of compilation errors.
4 years, 7 months ago (2016-05-04 16:11:33 UTC) #4
rmacnak
lgtm w/nit https://codereview.chromium.org/1916243002/diff/20001/runtime/vm/source_report_test.cc File runtime/vm/source_report_test.cc (right): https://codereview.chromium.org/1916243002/diff/20001/runtime/vm/source_report_test.cc#newcode152 runtime/vm/source_report_test.cc:152: "}" }\n https://codereview.chromium.org/1916243002/diff/20001/runtime/vm/source_report_test.cc#newcode195 runtime/vm/source_report_test.cc:195: "}" }\n https://codereview.chromium.org/1916243002/diff/20001/runtime/vm/source_report_test.cc#newcode239 ...
4 years, 7 months ago (2016-05-04 16:42:35 UTC) #5
turnidge
4 years, 7 months ago (2016-05-04 18:00:43 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
956ac4c18331824ed140d27d2b1ca5fa03f22c1b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698