Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Unified Diff: mojo/public/cpp/application/application_impl.h

Issue 1916233002: Mark ApplicationImpl::ConnectTo{Application,Service}() as deprecated. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/file_utils/file_util_unittest.cc ('k') | mojo/public/cpp/application/lib/application_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/application/application_impl.h
diff --git a/mojo/public/cpp/application/application_impl.h b/mojo/public/cpp/application/application_impl.h
index c3f90e3011b4ba48e234be5f232eb19c8a65f22e..cbb8fbae40b40c30f49d501e24c505b52afe854a 100644
--- a/mojo/public/cpp/application/application_impl.h
+++ b/mojo/public/cpp/application/application_impl.h
@@ -63,21 +63,24 @@ class ApplicationImpl : public Application {
// passing it to another thread.)
InterfaceHandle<ApplicationConnector> CreateApplicationConnector();
+ // DEPRECATED.
// Requests a new connection to an application. Returns a pointer to the
// connection if the connection is permitted by this application's delegate,
// or nullptr otherwise. Caller does not take ownership. The pointer remains
// valid until an error occurs on the connection with the Shell, or until the
// ApplicationImpl is destroyed, whichever occurs first.
// TODO(vtl): Deprecate/remove this.
- ApplicationConnection* ConnectToApplication(const String& application_url);
+ ApplicationConnection* ConnectToApplicationDeprecated(
+ const String& application_url);
+ // DEPRECATED. (You should probably use something from connect.h instead.)
// Connect to application identified by |application_url| and connect to the
// service implementation of the interface identified by |Interface|.
// TODO(vtl): Deprecate/remove this.
template <typename Interface>
- void ConnectToService(const std::string& application_url,
- InterfacePtr<Interface>* ptr) {
- ConnectToApplication(application_url)->ConnectToService(ptr);
+ void ConnectToServiceDeprecated(const std::string& application_url,
+ InterfacePtr<Interface>* ptr) {
+ ConnectToApplicationDeprecated(application_url)->ConnectToService(ptr);
}
// Blocks until the |Application| is initialized (i.e., |Initialize()| is
« no previous file with comments | « mojo/file_utils/file_util_unittest.cc ('k') | mojo/public/cpp/application/lib/application_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698