Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1916223004: Stop concatenating prefixes and identifiers when performing lookup (issue 26069) (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, sra1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop concatenating prefixes and identifiers when performing lookup (issue 26069) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/2bd7317edee49e5365e593e22dee52d95ed7356e

Patch Set 1 #

Patch Set 2 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -29 lines) Patch
M pkg/analyzer/lib/src/dart/ast/ast.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/scope.dart View 1 10 chunks +175 lines, -22 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 4 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 7 months ago (2016-04-26 20:27:09 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-04-26 20:40:16 UTC) #3
Brian Wilkerson
4 years, 7 months ago (2016-04-26 20:56:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2bd7317edee49e5365e593e22dee52d95ed7356e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698