Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: sdk/lib/io/socket.dart

Issue 1916223003: Fixes NetworkInterface.list crash on Android (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/js_runtime/lib/io_patch.dart ('k') | tests/standalone/io/network_interface_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/socket.dart
diff --git a/sdk/lib/io/socket.dart b/sdk/lib/io/socket.dart
index 4da5bb83e5c6e4ade3301fdc51c69f0b56017275..30e4eb2c2dda9d357bf466b1a8c71499aecb7ab4 100644
--- a/sdk/lib/io/socket.dart
+++ b/sdk/lib/io/socket.dart
@@ -145,8 +145,8 @@ abstract class InternetAddress {
/**
- * A [NetworkInterface] represent an active network interface on the current
- * system. It contains a list of [InternetAddress]s, that's bound to the
+ * A [NetworkInterface] represents an active network interface on the current
+ * system. It contains a list of [InternetAddress]es that are bound to the
* interface.
*/
abstract class NetworkInterface {
@@ -161,12 +161,19 @@ abstract class NetworkInterface {
String get index;
/**
- * Get a list of [InternetAddress]s currently bound to this
+ * Get a list of [InternetAddress]es currently bound to this
* [NetworkInterface].
*/
List<InternetAddress> get addresses;
/**
+ * Whether [list] is supported.
+ *
+ * [list] is currently unsupported on Android.
+ */
+ external static bool get listSupported;
+
+ /**
* Query the system for [NetworkInterface]s.
*
* If [includeLoopback] is `true`, the returned list will include the
« no previous file with comments | « sdk/lib/_internal/js_runtime/lib/io_patch.dart ('k') | tests/standalone/io/network_interface_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698