runtime/bin/socket_macos.cc - Issue 1916223003: Fixes NetworkInterface.list crash on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket_macos.cc

Issue 1916223003: Fixes NetworkInterface.list crash on Android (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/socket_macos.cc

diff --git a/runtime/bin/socket_macos.cc b/runtime/bin/socket_macos.cc

index 624da8e80dc84e333a0d7f592f22302bfefbcd89..708cd3cdea9bd926079f611df3870980e8563d57 100644

--- a/runtime/bin/socket_macos.cc

+++ b/runtime/bin/socket_macos.cc

@@ -336,6 +336,11 @@ static bool ShouldIncludeIfaAddrs(struct ifaddrs* ifa, int lookup_family) {

}

+bool Socket::ListInterfacesSupported() {

+ return true;

AddressList<InterfaceSocketAddress>* Socket::ListInterfaces(

int type,

OSError** os_error) {

« no previous file with comments | « runtime/bin/socket_linux.cc ('k') | runtime/bin/socket_patch.dart » ('j') | no next file with comments »