Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1916223003: Fixes NetworkInterface.list crash on Android (Closed)

Created:
4 years, 8 months ago by zra
Modified:
4 years, 8 months ago
Reviewers:
Cutch, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes NetworkInterface.list crash on Android Previously, Socket::ListInterfaces failed to set the os_error out parameter causing a crash in the caller. This change sets an error here. I've also added NetworkInterface.listSupported, which returns false on Android, and true everywhere else. ifaddrs.h continues not to exist in the NDK, so in order to support NetworkInterface.list, we'd have to reimplement it, or find a suitable reimplementation somewhere. related #26329 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/ba550f1c436724c0eabd3f48084d035e18ec50aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -3 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/io_natives.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/socket.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/socket.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/socket_android.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/bin/socket_linux.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/socket_macos.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/socket_patch.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/bin/socket_unsupported.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/socket_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/io_patch.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/io/socket.dart View 2 chunks +10 lines, -3 lines 0 comments Download
M tests/standalone/io/network_interface_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 8 months ago (2016-04-25 21:43:31 UTC) #2
Cutch
LGTM!
4 years, 8 months ago (2016-04-25 21:50:08 UTC) #3
zra
4 years, 8 months ago (2016-04-26 14:49:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ba550f1c436724c0eabd3f48084d035e18ec50aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698