|
Fixes NetworkInterface.list crash on Android
Previously, Socket::ListInterfaces failed to set the os_error out
parameter causing a crash in the caller. This change sets an error here.
I've also added NetworkInterface.listSupported, which returns false on
Android, and true everywhere else. ifaddrs.h continues not to exist in
the NDK, so in order to support NetworkInterface.list, we'd have to
reimplement it, or find a suitable reimplementation somewhere.
related #26329
R=johnmccutchan@google.com
Committed: https://github.com/dart-lang/sdk/commit/ba550f1c436724c0eabd3f48084d035e18ec50aa
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+68 lines, -3 lines) |
Patch |
|
M |
CHANGELOG.md
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/io_natives.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/socket.h
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/socket.cc
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/socket_android.cc
|
View
|
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/socket_linux.cc
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/socket_macos.cc
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/socket_patch.dart
|
View
|
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/socket_unsupported.cc
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/socket_win.cc
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
sdk/lib/_internal/js_runtime/lib/io_patch.dart
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
sdk/lib/io/socket.dart
|
View
|
|
2 chunks |
+10 lines, -3 lines |
0 comments
|
Download
|
|
M |
tests/standalone/io/network_interface_test.dart
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
Total messages: 5 (2 generated)
|