Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1916193005: [Media Router WebUI] Fix non-blocking issue banner styling. (Closed)

Created:
4 years, 8 months ago by apacible
Modified:
4 years, 8 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Fix non-blocking issue banner styling. Fixes text going off the banner instead of moving to the second line. BUG=606823 Committed: https://crrev.com/c3e61c88b2f43ec5542244944c3251b854cf08ec Cr-Commit-Position: refs/heads/master@{#389853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/media_router/elements/issue_banner/issue_banner.css View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
apacible
PTAL, thanks! Screenshots demonstrate text wrapping to the next line after a certain width. LTR: ...
4 years, 8 months ago (2016-04-26 17:16:41 UTC) #4
imcheng
lgtm
4 years, 8 months ago (2016-04-26 18:10:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916193005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916193005/1
4 years, 8 months ago (2016-04-26 18:23:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 19:41:57 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 19:44:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3e61c88b2f43ec5542244944c3251b854cf08ec
Cr-Commit-Position: refs/heads/master@{#389853}

Powered by Google App Engine
This is Rietveld 408576698