Change SuperFastHash signature to use size_t, not int.

Change SuperFastHash signature to use size_t, not int.

Move the size check and static_cast to from the generic Hash to the specific SuperFastHash wrapper.

Hash uses a reasonable size_t type, but the specific SuperFastHash uses an int for size. This is leaking a mistake from third_party code into our wrapper. Client code that wants to be clear that it is using SuperFastHash specifically (not just generic Hash) should be able to do so with a size_t type.

Committed: https://crrev.com/3bec18d235b327e9b18c1f7efa07c6fc46d32715
Cr-Commit-Position: refs/heads/master@{#389818}

[scheib, 2016-04-26 14:59:49]

Description was changed from

==========
Change SuperFastHash signature to use size_t, not int.
==========

to

==========
Change SuperFastHash signature to use size_t, not int.

Move the size check and static_cast to from the generic Hash to the specific
SuperFastHash wrapper.
==========

[scheib, 2016-04-26 15:02:34]

Description was changed from

==========
Change SuperFastHash signature to use size_t, not int.

Move the size check and static_cast to from the generic Hash to the specific
SuperFastHash wrapper.
==========

to

==========
Change SuperFastHash signature to use size_t, not int.

Move the size check and static_cast to from the generic Hash to the specific
SuperFastHash wrapper.

Hash uses a reasonable size_t type, but the specific SuperFastHash uses an int
for size. This is leaking a mistake from third_party code into our wrapper.
Client code that wants to be clear that it is using SuperFastHash specifically
(not just generic Hash) should be able to do so with a size_t type.
==========

[scheib, 2016-04-26 15:07:26]

scheib@chromium.org changed reviewers:
+ jam@chromium.org

[scheib, 2016-04-26 15:07:26]

This to fix casting error that was observed from 
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28d...

[jam, 2016-04-26 16:27:18]

On 2016/04/26 15:07:26, scheib wrote:
> This to fix casting error that was observed from 
>
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28d...

please send to base/ owner

[scheib, 2016-04-26 17:05:31]

scheib@chromium.org changed reviewers:
+ thakis@chromium.org
- jam@chromium.org

[scheib, 2016-04-26 17:05:56]

This to fix casting error that was observed from 
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28d...

[Nico, 2016-04-26 17:39:41]

We have 'msvs_disabled_warnings': [4267, ],' all over the place, maybe your
target just needs that too?

[Nico, 2016-04-26 17:41:03]

But lgtm if you want to land this.

[scheib, 2016-04-26 17:58:04]

;| suppressing 4267 is a tad unfortunate. I think having the code intentionally
handle this makes sense, so I'll land.

[scheib, 2016-04-26 17:58:11]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2016-04-26 17:58:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916193003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916193003/1

[commit-bot: I haz the power, 2016-04-26 18:03:30]

Description was changed from

==========
Change SuperFastHash signature to use size_t, not int.

Move the size check and static_cast to from the generic Hash to the specific
SuperFastHash wrapper.

Hash uses a reasonable size_t type, but the specific SuperFastHash uses an int
for size. This is leaking a mistake from third_party code into our wrapper.
Client code that wants to be clear that it is using SuperFastHash specifically
(not just generic Hash) should be able to do so with a size_t type.
==========

to

==========
Change SuperFastHash signature to use size_t, not int.

Move the size check and static_cast to from the generic Hash to the specific
SuperFastHash wrapper.

Hash uses a reasonable size_t type, but the specific SuperFastHash uses an int
for size. This is leaking a mistake from third_party code into our wrapper.
Client code that wants to be clear that it is using SuperFastHash specifically
(not just generic Hash) should be able to do so with a size_t type.
==========

[commit-bot: I haz the power, 2016-04-26 18:03:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-26 18:05:11]

Description was changed from

==========
Change SuperFastHash signature to use size_t, not int.

Move the size check and static_cast to from the generic Hash to the specific
SuperFastHash wrapper.

Hash uses a reasonable size_t type, but the specific SuperFastHash uses an int
for size. This is leaking a mistake from third_party code into our wrapper.
Client code that wants to be clear that it is using SuperFastHash specifically
(not just generic Hash) should be able to do so with a size_t type.
==========

to

==========
Change SuperFastHash signature to use size_t, not int.

Move the size check and static_cast to from the generic Hash to the specific
SuperFastHash wrapper.

Hash uses a reasonable size_t type, but the specific SuperFastHash uses an int
for size. This is leaking a mistake from third_party code into our wrapper.
Client code that wants to be clear that it is using SuperFastHash specifically
(not just generic Hash) should be able to do so with a size_t type.

Committed: https://crrev.com/3bec18d235b327e9b18c1f7efa07c6fc46d32715
Cr-Commit-Position: refs/heads/master@{#389818}
==========

[commit-bot: I haz the power, 2016-04-26 18:05:12]

Patchset 1 (id:??) landed as
https://crrev.com/3bec18d235b327e9b18c1f7efa07c6fc46d32715
Cr-Commit-Position: refs/heads/master@{#389818}

[Nico, 2016-04-26 18:19:04]

On 2016/04/26 17:58:04, scheib wrote:
> ;| suppressing 4267 is a tad unfortunate.

I don't disagree, but it's suppressed almost everywhere atm.