Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 1916183004: Eliminate support for V0 manifests, migrate all to V1. (Closed)

Created:
4 years, 7 months ago by Ben Goodger (Google)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), feature-media-reviews_chromium.org, kalyank, qsr+mojo_chromium.org, sadrul, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@explicit
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate support for V0 manifests, migrate all to V1. . Also removes a bunch of [D]CHECKs from manifest parsing. Error reporting isn't perfect yet (file names aren't reported)... but this'll do for now. A future incarnation might replace the LOGs with an error recorder passed into Deserialize() from the caller, which can then LOG the result with context about what was being deserialized. R=rockot@chromium.org BUG= Committed: https://crrev.com/44e1d5dc7a9bac1aa8d7ec01dce4ba8a2338d312 Cr-Commit-Position: refs/heads/master@{#390114}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -91 lines) Patch
M chrome/app/mash/chrome_mash_manifest.json View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/app/mojo/chrome_renderer_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M components/filesystem/manifest.json View 1 chunk +6 lines, -1 line 0 comments Download
M components/filesystem/test_manifest.json View 1 1 chunk +6 lines, -1 line 0 comments Download
M components/leveldb/leveldb_service_unittest.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M components/leveldb/manifest.json View 1 chunk +6 lines, -1 line 0 comments Download
M components/leveldb/test_manifest.json View 1 1 chunk +7 lines, -1 line 0 comments Download
M components/resource_provider/test_manifest.json View 1 chunk +6 lines, -1 line 0 comments Download
M components/resource_provider/unittests_manifest.json View 1 1 chunk +6 lines, -1 line 0 comments Download
M mash/browser_driver/manifest.json View 1 chunk +6 lines, -1 line 0 comments Download
M mash/example/window_type_launcher/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/services/apptest_manifest.json View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
M media/mojo/services/media_manifest.json View 1 chunk +6 lines, -1 line 0 comments Download
M media/mojo/services/pipeline_apptest_manifest.json View 1 chunk +6 lines, -1 line 0 comments Download
M services/catalog/data/capabilities View 1 chunk +4 lines, -1 line 0 comments Download
M services/catalog/data/instance View 1 chunk +2 lines, -1 line 0 comments Download
M services/catalog/data/malformed View 1 chunk +1 line, -0 lines 0 comments Download
M services/catalog/data/simple View 1 chunk +2 lines, -1 line 0 comments Download
M services/catalog/entry.cc View 2 chunks +101 lines, -57 lines 0 comments Download
M services/catalog/reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/shell/runner/child/manifest.json View 1 chunk +6 lines, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_app_b_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_driver_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_exe_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_package_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/tests/lifecycle/app_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/tests/lifecycle/exe_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/tests/lifecycle/package_app_a_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/tests/lifecycle/package_app_b_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/tests/lifecycle/package_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/tests/shell/shell_unittest_manifest.json View 1 chunk +7 lines, -1 line 0 comments Download
M services/shell/tests/shell/target_manifest.json View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 20 (11 generated)
Ben Goodger (Google)
4 years, 7 months ago (2016-04-26 21:51:06 UTC) #2
Ken Rockot(use gerrit already)
lgtm in general but looks like mus views and/or ws unit tests need an update ...
4 years, 7 months ago (2016-04-26 23:34:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916183004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916183004/20001
4 years, 7 months ago (2016-04-27 03:32:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916183004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916183004/40001
4 years, 7 months ago (2016-04-27 03:33:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/128408)
4 years, 7 months ago (2016-04-27 03:43:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916183004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916183004/40001
4 years, 7 months ago (2016-04-27 14:34:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916183004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916183004/60001
4 years, 7 months ago (2016-04-27 16:22:31 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-04-27 17:24:52 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:10:55 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/44e1d5dc7a9bac1aa8d7ec01dce4ba8a2338d312
Cr-Commit-Position: refs/heads/master@{#390114}

Powered by Google App Engine
This is Rietveld 408576698