Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1916183003: Forward accept_IN to ParseYieldExpression (Closed)

Created:
4 years, 8 months ago by adamk
Modified:
4 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Forward accept_IN to ParseYieldExpression This allows "yield 'x' in o" as an expression in a generator. R=ishell@chromium.org BUG=v8:4945 LOG=n Committed: https://crrev.com/967a04634d2db218986ce189c5fa223d86b104f1 Cr-Commit-Position: refs/heads/master@{#35798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M src/parsing/parser-base.h View 4 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-4945.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
4 years, 8 months ago (2016-04-26 00:07:05 UTC) #1
Igor Sheludko
lgtm
4 years, 8 months ago (2016-04-26 10:11:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916183003/1
4 years, 8 months ago (2016-04-26 17:22:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 17:24:32 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 17:25:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/967a04634d2db218986ce189c5fa223d86b104f1
Cr-Commit-Position: refs/heads/master@{#35798}

Powered by Google App Engine
This is Rietveld 408576698