Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Issue 1916183002: Return error code when get_images_from_skps has failures (Closed)

Created:
4 years, 8 months ago by rmistry
Modified:
4 years, 8 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 : Initial upload #

Patch Set 2 : Return -1 when failures #

Patch Set 3 : Fix #

Patch Set 4 : Undo test change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M tools/get_images_from_skps.cpp View 1 2 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
rmistry
4 years, 8 months ago (2016-04-26 15:02:13 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916183002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916183002/60001
4 years, 8 months ago (2016-04-26 15:03:09 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 15:21:45 UTC) #9
msarett
LGTM
4 years, 8 months ago (2016-04-26 15:25:17 UTC) #10
commit-bot: I haz the power
COMMIT=false detected. CQ is abandoning the patch.
4 years, 8 months ago (2016-04-26 15:26:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916183002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916183002/60001
4 years, 8 months ago (2016-04-26 15:26:54 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 15:27:53 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/cda08f84907136186ee2dcfde1dd04a8531e5315

Powered by Google App Engine
This is Rietveld 408576698