Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1916173003: Don't use a magic value for 'auto' oriented <marker>s (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use a magic value for 'auto' oriented <marker>s The value -1 (degrees) is a valid angle, so using it to indicate that 'auto' orientation should be used does not work out. Just check 'orientType' directly instead and simplify the angle getter. BUG=606345 Committed: https://crrev.com/886546446df947816927a7757de45fab1646c919 Cr-Commit-Position: refs/heads/master@{#390029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
A third_party/WebKit/LayoutTests/svg/markers/marker-orientation-minus-one.html View 1 chunk +7 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/markers/marker-orientation-minus-one-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp View 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
fs
4 years, 8 months ago (2016-04-26 17:21:01 UTC) #2
Stephen Chennney
lgtm. I wish we could magically find all the horrid code that still exists.
4 years, 8 months ago (2016-04-26 17:45:01 UTC) #3
fs
On 2016/04/26 at 17:45:01, schenney wrote: > lgtm. I wish we could magically find all ...
4 years, 8 months ago (2016-04-26 18:05:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916173003/1
4 years, 8 months ago (2016-04-26 18:05:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/60533)
4 years, 8 months ago (2016-04-26 20:02:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916173003/1
4 years, 8 months ago (2016-04-27 09:06:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-27 09:13:21 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-27 09:15:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/886546446df947816927a7757de45fab1646c919
Cr-Commit-Position: refs/heads/master@{#390029}

Powered by Google App Engine
This is Rietveld 408576698