Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1916143003: Quick step 1: dump stack in AbstractType::IsInstantiated (Closed)

Created:
4 years, 8 months ago by srdjan
Modified:
4 years, 8 months ago
Reviewers:
regis, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Quick step 1: dump stack in AbstractType::IsInstantiated Later: attempt to tie it in with all FATALs BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/c46fe8c23f79ff15400bfa1ec764acafa2b7da44

Patch Set 1 #

Total comments: 2

Patch Set 2 : Both #

Total comments: 2

Patch Set 3 : sync #

Patch Set 4 : order changed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/vm/object.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
srdjan
4 years, 8 months ago (2016-04-25 23:04:38 UTC) #2
regis
https://codereview.chromium.org/1916143003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1916143003/diff/1/runtime/vm/object.cc#newcode15519 runtime/vm/object.cc:15519: Profiler::DumpStackTrace(); LGTM but how about dumping both native and ...
4 years, 8 months ago (2016-04-25 23:13:49 UTC) #3
srdjan
https://codereview.chromium.org/1916143003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1916143003/diff/1/runtime/vm/object.cc#newcode15519 runtime/vm/object.cc:15519: Profiler::DumpStackTrace(); On 2016/04/25 23:13:49, regis wrote: > LGTM but ...
4 years, 8 months ago (2016-04-25 23:14:33 UTC) #4
Cutch
https://codereview.chromium.org/1916143003/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1916143003/diff/20001/runtime/vm/object.cc#newcode15520 runtime/vm/object.cc:15520: Profiler::DumpStackTrace(false); DBC: Call it with false first and then ...
4 years, 8 months ago (2016-04-25 23:16:11 UTC) #6
srdjan
https://codereview.chromium.org/1916143003/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1916143003/diff/20001/runtime/vm/object.cc#newcode15520 runtime/vm/object.cc:15520: Profiler::DumpStackTrace(false); On 2016/04/25 23:16:11, Cutch wrote: > DBC: Call ...
4 years, 8 months ago (2016-04-25 23:29:16 UTC) #7
srdjan
4 years, 8 months ago (2016-04-25 23:29:35 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
c46fe8c23f79ff15400bfa1ec764acafa2b7da44 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698