Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1916133003: Fix the build script to be able to build more than one generator. (Closed)

Created:
4 years, 8 months ago by azani
Modified:
4 years, 8 months ago
Reviewers:
rudominer
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix the build script to be able to build more than one generator. The generator build script used to return at the end of the body of its outter loop courtesy of python's syntax. Also, adding a flag to specify a list of generators to be built. R=rudominer@chromium.org, rudominer Committed: https://chromium.googlesource.com/external/mojo/+/fbcd0af62fc91b1e03d4c49e4feffe5bca147404

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M mojom/tools/build_generators.py View 1 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
azani
4 years, 8 months ago (2016-04-25 23:08:49 UTC) #1
rudominer
The description should say "to be able to build more than one generator" should it ...
4 years, 8 months ago (2016-04-25 23:16:06 UTC) #2
azani
ptal See line 49 on patch 2. That line used to have one extra level ...
4 years, 8 months ago (2016-04-26 00:03:27 UTC) #4
rudominer
lgtm
4 years, 8 months ago (2016-04-26 00:16:38 UTC) #5
azani
4 years, 8 months ago (2016-04-26 00:17:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fbcd0af62fc91b1e03d4c49e4feffe5bca147404 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698