Fix the build script to be able to build more than one generator.

Fix the build script to be able to build more than one generator.

The generator build script used to return at the end of the body of its outter loop courtesy of python's syntax.
Also, adding a flag to specify a list of generators to be built.

R=rudominer@chromium.org, rudominer

Committed: https://chromium.googlesource.com/external/mojo/+/fbcd0af62fc91b1e03d4c49e4feffe5bca147404

[rudominer, 2016-04-25 23:16:06]

The description should say "to be able to build more than one generator" should
it not? 

Is that really what this change is doing anyway? Isn't it adding a flag to
override the default list of generators to be built (which happens to contain
one thing at the moment.)

https://codereview.chromium.org/1916133003/diff/1/mojom/tools/build_generator...
File mojom/tools/build_generators.py (right):

https://codereview.chromium.org/1916133003/diff/1/mojom/tools/build_generator...
mojom/tools/build_generators.py:20: action='store', help='')
I think a help string with an example would be useful.

https://codereview.chromium.org/1916133003/diff/1/mojom/tools/build_generator...
mojom/tools/build_generators.py:24: 'deps',
The default should be to build all of the generators, right?

[azani, 2016-04-26 00:02:09]

Description was changed from

==========
Fix the build script to be able to run more than one generator.

The generator build script used to return at the end of the body of its
outter loop courtesy of python's syntax.
Also, adding a flag to specify a list of generators to be built.

R=rudominer
==========

to

==========
Fix the build script to be able to run more than one generator.

The generator build script used to return at the end of the body of its outter
loop courtesy of python's syntax.
Also, adding a flag to specify a list of generators to be built.

R=rudominer
==========

[azani, 2016-04-26 00:03:27]

ptal

See line 49 on patch 2. That line used to have one extra level of indentation
which means it was executed at the end of the body of the loop instead of after
the loop.

https://codereview.chromium.org/1916133003/diff/1/mojom/tools/build_generator...
File mojom/tools/build_generators.py (right):

https://codereview.chromium.org/1916133003/diff/1/mojom/tools/build_generator...
mojom/tools/build_generators.py:20: action='store', help='')
On 2016/04/25 23:16:05, rudominer wrote:
> I think a help string with an example would be useful.

Woops, I forgot the help string. Right now, there is only deps, so I don't think
an example is useful here.

https://codereview.chromium.org/1916133003/diff/1/mojom/tools/build_generator...
mojom/tools/build_generators.py:24: 'deps',
On 2016/04/25 23:16:05, rudominer wrote:
> The default should be to build all of the generators, right?

It is.

[rudominer, 2016-04-26 00:16:38]

lgtm

[azani, 2016-04-26 00:16:55]

Description was changed from

==========
Fix the build script to be able to run more than one generator.

The generator build script used to return at the end of the body of its outter
loop courtesy of python's syntax.
Also, adding a flag to specify a list of generators to be built.

R=rudominer
==========

to

==========
Fix the build script to be able to build more than one generator.

The generator build script used to return at the end of the body of its outter
loop courtesy of python's syntax.
Also, adding a flag to specify a list of generators to be built.

R=rudominer
==========

[azani, 2016-04-26 00:17:17]

Description was changed from

==========
Fix the build script to be able to build more than one generator.

The generator build script used to return at the end of the body of its outter
loop courtesy of python's syntax.
Also, adding a flag to specify a list of generators to be built.

R=rudominer
==========

to

==========
Fix the build script to be able to build more than one generator.

The generator build script used to return at the end of the body of its outter
loop courtesy of python's syntax.
Also, adding a flag to specify a list of generators to be built.

R=rudominer@chromium.org, rudominer

Committed:
https://chromium.googlesource.com/external/mojo/+/fbcd0af62fc91b1e03d4c49e4fe...
==========

[azani, 2016-04-26 00:17:18]

Committed patchset #2 (id:20001) manually as
fbcd0af62fc91b1e03d4c49e4feffe5bca147404 (presubmit successful).