Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1916133002: Remove mpcomplete from OWNERS files (Closed)

Created:
4 years, 8 months ago by asargent_no_longer_on_chrome
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, Ken Rockot(use gerrit already)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove mpcomplete from OWNERS files Matt isn't working on chrome stuff anymore Committed: https://crrev.com/131c20ce51c10a32516a2e53ea65c8679aa5eba5 Cr-Commit-Position: refs/heads/master@{#389860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M chrome/browser/extensions/api/declarative/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
D chrome/browser/extensions/api/omnibox/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M components/json_schema/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/utility/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D extensions/browser/api/alarms/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
asargent_no_longer_on_chrome
4 years, 8 months ago (2016-04-25 19:25:53 UTC) #2
mpcomplete
LGTM, thanks!
4 years, 8 months ago (2016-04-25 19:28:48 UTC) #3
asargent_no_longer_on_chrome
ben - can you review the content/utility/OWNERS change? I'm removing mpcomplete, which leaves that file ...
4 years, 8 months ago (2016-04-25 21:35:47 UTC) #5
Ben Goodger (Google)
lgtm
4 years, 8 months ago (2016-04-25 23:18:58 UTC) #6
asargent_no_longer_on_chrome
From offline conversation with Ken, sounds like this directory doesn't necessarily need specific owners and ...
4 years, 8 months ago (2016-04-26 19:07:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916133002/1
4 years, 8 months ago (2016-04-26 19:08:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 19:57:44 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 20:00:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/131c20ce51c10a32516a2e53ea65c8679aa5eba5
Cr-Commit-Position: refs/heads/master@{#389860}

Powered by Google App Engine
This is Rietveld 408576698