Use bitfield rather than distinct enum types for circular corners in RRectEffect.

Use bitfield rather than distinct enum types for circular corners in RRectEffect.

BUG=skia:2181
Committed: http://code.google.com/p/skia/source/detail?r=13723

[bsalomon, 2014-03-10 14:13:58]

Preparation for handling the single-rounded-corner case.

[robertphillips, 2014-03-10 14:30:26]

lgtm modulo 1 issue

https://codereview.chromium.org/191613003/diff/20001/src/gpu/effects/GrRRectE...
File src/gpu/effects/GrRRectEffect.cpp (right):

https://codereview.chromium.org/191613003/diff/20001/src/gpu/effects/GrRRectE...
src/gpu/effects/GrRRectEffect.cpp:27: kTopRight_CornerFlag    = (1 <<
SkRRect::kUpperRight_Corner),
Should these two be ordered to match the order in SkRRect's enum? I'm surprised
you're not seeing artifacts.

[bsalomon, 2014-03-10 15:16:38]

https://codereview.chromium.org/191613003/diff/20001/src/gpu/effects/GrRRectE...
File src/gpu/effects/GrRRectEffect.cpp (right):

https://codereview.chromium.org/191613003/diff/20001/src/gpu/effects/GrRRectE...
src/gpu/effects/GrRRectEffect.cpp:27: kTopRight_CornerFlag    = (1 <<
SkRRect::kUpperRight_Corner),
On 2014/03/10 14:30:26, robertphillips wrote:
> Should these two be ordered to match the order in SkRRect's enum? I'm
surprised
> you're not seeing artifacts.

The order doesn't affect the values assigned, but changed it for consistency.

[bsalomon, 2014-03-10 15:16:41]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-03-10 15:17:23]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/191613003/30002

[commit-bot: I haz the power, 2014-03-10 16:08:48]

Change committed as 13723