Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1916053006: Support USB transfers from arbitrary threads in the new Linux backend. (Closed)

Created:
4 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 7 months ago
Reviewers:
juncai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support USB transfers from arbitrary threads in the new Linux backend. DevTools relies on being able to issue USB transfers from an arbitrary thread and have the callback run back on that thread. This is possible in the libusb version but not the new native Linux version. This patch adds the necessary thread hopping logic for that but only for bulk and interrupt transfers as DevTools only uses those. BUG=603434 Committed: https://crrev.com/6aa3211e5f2b8a4bbe400e24d448d2ceb4c60115 Cr-Commit-Position: refs/heads/master@{#390227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -48 lines) Patch
M device/usb/usb_device_handle_usbfs.h View 4 chunks +12 lines, -2 lines 0 comments Download
M device/usb/usb_device_handle_usbfs.cc View 10 chunks +94 lines, -46 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 7 months ago (2016-04-27 21:15:56 UTC) #2
juncai
LGTM.
4 years, 7 months ago (2016-04-27 22:08:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916053006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916053006/1
4 years, 7 months ago (2016-04-27 22:13:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 23:11:46 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:14:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6aa3211e5f2b8a4bbe400e24d448d2ceb4c60115
Cr-Commit-Position: refs/heads/master@{#390227}

Powered by Google App Engine
This is Rietveld 408576698