Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1916053003: Add toStructuredText to ConstantExpression and align method names with ConstantValue (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add toStructuredText to ConstantExpression and align method names with ConstantValue R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/4acfa253d317a9e3b662f5ff34b8b140f90bf83e

Patch Set 1 #

Patch Set 2 : dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -156 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 1 2 chunks +6 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/constants/constructors.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 28 chunks +208 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 19 chunks +40 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 4 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_dump.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 1 2 chunks +8 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_result.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/constant_serialization.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/json_serializer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/values.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/types/value_type_mask.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/const_exp_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/constant_expression_evaluate_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/constant_expression_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_decl_visitor.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart View 27 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 8 months ago (2016-04-26 10:12:49 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 8 months ago (2016-04-27 01:02:11 UTC) #3
Johnni Winther
4 years, 7 months ago (2016-04-27 10:48:58 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4acfa253d317a9e3b662f5ff34b8b140f90bf83e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698