Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1916053002: Make NeedsRebaseline illegal in layout_test TestExpectations for now. (Closed)

Created:
4 years, 8 months ago by wkorman
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make NeedsRebaseline illegal in layout_test TestExpectations for now. Also re-disable fast/text tests on Mac10.9. Mac 10.9 try servers still showing fast/text failure discrepancy vs builders. This reverts commit c9fe23264fc91bfdea90cb6c990aaaa09c40e210. BUG=603753 TBR=dpranke@chromium.org Committed: https://crrev.com/665f54d1ce5562993bfd2108970dda85587c1618 Cr-Commit-Position: refs/heads/master@{#389511}

Patch Set 1 #

Patch Set 2 : Fix bug number. #

Patch Set 3 : Sync to head. #

Patch Set 4 : Again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +197 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 18:24:15 UTC) #3
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/665f54d1ce5562993bfd2108970dda85587c1618
Cr-Commit-Position: refs/heads/master@{#389511}

Powered by Google App Engine
This is Rietveld 408576698