Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1916033002: Revert of [tracing] Add native allocation tracing mode. (Closed)

Created:
4 years, 7 months ago by Charlie Reis
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, Dai Mikurube (NOT FULLTIME), ssid
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tracing] Add native allocation tracing mode. (patchset #15 id:270001 of https://codereview.chromium.org/1839503002/ ) Reason for revert: Appears to have caused a compile error on https://build.chromium.org/p/chromium/builders/Win%20x64/builds/92. Original issue's description: > [tracing] Add native allocation tracing mode. > > This change adds 'native' mode to '--enable-heap-profiling' option. When > started with '--enable-heap-profiling=native' Chrome will keep native > (real) stack traces for all live allocations. These native stack traces > are then dumped to a trace file if 'memory-infra' category is enabled. > Stack traces are dumped unsymbolized (for performance reasons), and there > is a script (third_party/catapult/tracing/bin/symbolize_trace) that > symbolizes all stack traces in a given trace file. > > Design document: https://goo.gl/DFoqfi > > Note: native stack tracing relies on frame pointers. You'll need to use > either debug or a profiling release build (enable_profiling = true). > > Note: for now this all works on Linux @ x86/x64 only. > > BUG=602701 > > Committed: https://crrev.com/5a05938adaabf413a40f1e0dfec3d1e4c683693a > Cr-Commit-Position: refs/heads/master@{#389500} TBR=primiano@chromium.org,perezju@chromium.org,ssid@chromium.org,mark@chromium.org,dskiba@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=602701 Committed: https://crrev.com/2a03e86fcfb6f831ef8658cbd360f54bb5ace62e Cr-Commit-Position: refs/heads/master@{#389507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -156 lines) Patch
M base/base_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/base_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/trace_event/heap_profiler.h View 1 chunk +4 lines, -8 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_context.h View 4 chunks +6 lines, -10 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_context_tracker.h View 3 chunks +12 lines, -29 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_context_tracker.cc View 3 chunks +19 lines, -60 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_context_tracker_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M base/trace_event/heap_profiler_stack_frame_deduplicator.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 chunk +1 line, -20 lines 0 comments Download
M base/trace_event/trace_event.h View 1 chunk +4 lines, -8 lines 0 comments Download
M base/trace_event/trace_log.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Charlie Reis
Created Revert of [tracing] Add native allocation tracing mode.
4 years, 7 months ago (2016-04-25 17:12:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916033002/1
4 years, 7 months ago (2016-04-25 17:12:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-25 17:13:17 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-04-25 17:14:37 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a03e86fcfb6f831ef8658cbd360f54bb5ace62e
Cr-Commit-Position: refs/heads/master@{#389507}

Powered by Google App Engine
This is Rietveld 408576698