Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 1916003002: Fixes possible deadlock in fontservice (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes possible deadlock in fontservice Here's the sequence: 1. FontServiceThread::OpenStreamImpl 2. FontService::OpenStream 3. FontServiceThread::OnOpenStreamComplete If between 2 and 3 FontService gets a connection error the callback that calls OnOpenStreamComplete is never received, and the thread that called OpenStream() is stuck forever. Fix is to add the WaitableEvents to a member variable and if a connection error is received all WaitableEvents are signaled. BUG=594600 TEST=none R=erg@chromium.org Committed: https://crrev.com/b8d418d3c26048ed54ce7039bcc4c627a6804c54 Cr-Commit-Position: refs/heads/master@{#389515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M components/font_service/public/cpp/font_service_thread.h View 3 chunks +17 lines, -0 lines 0 comments Download
M components/font_service/public/cpp/font_service_thread.cc View 4 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 7 months ago (2016-04-25 15:40:25 UTC) #1
Elliot Glaysher
lgtm
4 years, 7 months ago (2016-04-25 18:15:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916003002/1
4 years, 7 months ago (2016-04-25 18:20:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-25 18:26:12 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-04-25 18:28:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8d418d3c26048ed54ce7039bcc4c627a6804c54
Cr-Commit-Position: refs/heads/master@{#389515}

Powered by Google App Engine
This is Rietveld 408576698