[Sync] Fix crash in GCP when adding encrypted entry that already exists.

sync/internal_api/sync_manager_impl_unittest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Unit tests for the SyncApi. Note that a lot of the underlying
 // functionality is provided by the Syncable layer, which has its own
 // unit tests. We'll test SyncApi specific things in this harness.
 
 #include "sync/internal_api/sync_manager_impl.h"
 
@@ skipping 763 matching lines @@
     WriteTransaction trans(FROM_HERE, user_share());
     WriteNode node(&trans);
     EXPECT_EQ(BaseNode::INIT_OK, node.InitByIdLookup(item1));
     node.Tombstone();
   }
 
   // Verify that it is gone from the index.
   EXPECT_EQ(1, GetTotalNodeCount(user_share(), preferences_root));
 }
 
+// Tests that InitUniqueByCreation called for existing encrypted entry properly
+// decrypts specifics and pust them in BaseNode::unencrypted_data_.
+TEST_F(SyncApiTest, WriteNode_UniqueByCreation_EncryptedExistingEntry) {
+  KeyParams params = {"localhost", "username", "passphrase"};
+  {
+    ReadTransaction trans(FROM_HERE, user_share());
+    trans.GetCryptographer()->AddKey(params);
+  }
+  encryption_handler()->EnableEncryptEverything();
+  WriteTransaction trans(FROM_HERE, user_share());
+  ReadNode root_node(&trans);
+  root_node.InitByRootLookup();
+
+  {
+    WriteNode pref_node(&trans);
+    WriteNode::InitUniqueByCreationResult result =
+        pref_node.InitUniqueByCreation(PREFERENCES, root_node, "bar");
+    ASSERT_EQ(WriteNode::INIT_SUCCESS, result);
+    pref_node.SetTitle("bar");
+    sync_pb::EntitySpecifics entity_specifics;
+    entity_specifics.mutable_preference();
+    pref_node.SetEntitySpecifics(entity_specifics);
+  }
+  {
+    WriteNode pref_node(&trans);
+    WriteNode::InitUniqueByCreationResult result =
+        pref_node.InitUniqueByCreation(PREFERENCES, root_node, "bar");
+    ASSERT_EQ(WriteNode::INIT_SUCCESS, result);
+    // Call GetEntitySpecifics, ensure it doesn't DCHECK.
+    pref_node.GetEntitySpecifics();
+  }
+}
+
 namespace {
 
 class TestHttpPostProviderInterface : public HttpPostProviderInterface {
  public:
   ~TestHttpPostProviderInterface() override {}
 
   void SetExtraRequestHeaders(const char* headers) override {}
   void SetURL(const char* url, int port) override {}
   void SetPostPayload(const char* content_type,
                       int content_length,
@@ skipping 2577 matching lines @@
 // SyncManagerInitInvalidStorageTest::GetFactory will return
 // DirectoryBackingStore that ensures that SyncManagerImpl::OpenDirectory fails.
 // SyncManagerImpl initialization is done in SyncManagerTest::SetUp. This test's
 // task is to ensure that SyncManagerImpl reported initialization failure in
 // OnInitializationComplete callback.
 TEST_F(SyncManagerInitInvalidStorageTest, FailToOpenDatabase) {
   EXPECT_FALSE(initialization_succeeded_);
 }
 
 }  // namespace syncer